From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Alexandr Miloslavskiy" <alexandr.miloslavskiy@syntevo.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v3 1/1] vreportf(): avoid relying on stdio buffering
Date: Thu, 31 Oct 2019 02:24:54 -0400 [thread overview]
Message-ID: <20191031062454.GB20830@sigill.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1910300947410.46@tvgsbejvaqbjf.bet>
On Wed, Oct 30, 2019 at 09:54:52AM +0100, Johannes Schindelin wrote:
> > One non-bikeshed question: would fprintf() on some platforms have sent
> > "\r\n", which is no longer happening with our write()? Do we need to
> > care about that?
>
> I am not aware of any platform where `fprintf()` would automatically
> transform `\n` to `\r\n`. Not unless the `FILE *` in question has been
> opened with the `t` flag. And I am rather certain that `stderr` is not
> opened with that flag. And if it was, I would force it off in Git for
> Windows.
OK, thanks. You guessed the platform I was thinking of. :)
Another more far-fetched one: IIRC our stdio wrappers on Windows do some
magic to convert ANSI color codes into actual terminal codes. Could that
be a problem here? I think we'd kill off any color codes in the actual
message due to the control-code replacement. In theory the prefix could
have them. I don't think any code does now, but the PUSH_COLOR_ERROR
stuff in builtin/push.c is getting close. I wouldn't be surprised for
that to eventually get folded into error().
-Peff
next prev parent reply other threads:[~2019-10-31 6:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 15:00 [PATCH 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-28 15:00 ` [PATCH 1/1] vreportf(): avoid buffered write in favor of unbuffered one Johannes Schindelin via GitGitGadget
2019-10-29 3:18 ` Junio C Hamano
2019-10-29 12:30 ` Johannes Schindelin
2019-10-29 13:49 ` Jeff King
2019-10-29 14:13 ` Johannes Schindelin
2019-10-29 14:32 ` Jeff King
2019-10-29 20:09 ` Johannes Schindelin
2019-10-30 1:43 ` Junio C Hamano
2019-10-29 16:44 ` Junio C Hamano
2019-10-29 10:38 ` SZEDER Gábor
2019-10-29 12:38 ` Johannes Schindelin
2019-10-29 13:52 ` Jeff King
2019-10-29 14:18 ` Johannes Schindelin
2019-10-29 13:37 ` [PATCH v2 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-29 13:37 ` [PATCH v2 1/1] vreportf(): avoid relying on stdio buffering Johannes Schindelin via GitGitGadget
2019-10-29 14:21 ` Alexandr Miloslavskiy
2019-10-29 19:57 ` Johannes Schindelin
2019-10-29 20:09 ` Jeff King
2019-10-29 20:24 ` Alexandr Miloslavskiy
2019-10-29 20:11 ` Alexandr Miloslavskiy
2019-10-29 20:01 ` [PATCH v3 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-29 20:01 ` [PATCH v3 1/1] vreportf(): avoid relying on stdio buffering Johannes Schindelin via GitGitGadget
2019-10-29 20:32 ` Jeff King
2019-10-30 8:54 ` Johannes Schindelin
2019-10-31 6:24 ` Jeff King [this message]
2019-10-31 10:26 ` Johannes Schindelin
2019-10-31 15:48 ` Jeff King
2019-11-01 18:41 ` Johannes Schindelin
2019-10-30 2:01 ` Junio C Hamano
2019-10-30 9:13 ` Johannes Schindelin
2019-10-30 10:44 ` [PATCH v4 0/1] Fix t5516 flakiness in Visual Studio builds Johannes Schindelin via GitGitGadget
2019-10-30 10:44 ` [PATCH v4 1/1] vreportf(): avoid relying on stdio buffering Johannes Schindelin via GitGitGadget
2019-11-02 4:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031062454.GB20830@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=alexandr.miloslavskiy@syntevo.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).