git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: git@vger.kernel.org
Subject: Re: git fsck, badDate: invalid author/committer line - bad date
Date: Thu, 31 Oct 2019 17:56:32 +0100	[thread overview]
Message-ID: <20191031165632.GA4348@szeder.dev> (raw)
In-Reply-To: <20191031142118.747693c1.olaf@aepfle.de>

On Thu, Oct 31, 2019 at 02:21:18PM +0100, Olaf Hering wrote:
> Am Thu, 31 Oct 2019 11:15:39 +0100
> schrieb SZEDER Gábor <szeder.dev@gmail.com>:
> 
> > However, I don't know how to tell about the skiplist file to GitHub,
> > or any other Git hosting service for that matter.
> 
> Thanks for all the details.
> 
> Is there a way to "replay" a git repository, so that all the commit contents
> and author/committer data are preserved? I think it is more important to have
> a clean repository than to preserve irrelevant commit hashes.

Those commits can be fixed by simply transforming the fast-export
stream, e.g.:

  $ git init new
  $ git -C virt-top/ fast-export --all |
    sed -e '/^\(author\|committer\) Richard W\.M\. Jones <rjones@redhat.com> </ s/<"Richard W\.M\. Jones <rjones@redhat.com>"> //' |
    git -C new fast-import

BUT!

All the usual warnings about rewriting already published history
apply.  The hash of a couple of commits from 2009 might seem
irrelevant now, a decade later, but after correcting those author and
committer lines the hashes of all subsequent commits will inherently
change as well.  This is, in general, upsetting for everyone who have
cloned the repo and built their own work on top.  Furthermore, some
commit messages refer to older commits by their hash (e.g. in
431dbd98ba: "Simplifies and updates commit
dbef8dd3bf00417e75a12c851b053e49c9e1a79e"); those references will go
stale after rewriting history, unless you put in extra work to update
them.

I would advise against rewriting history.


  reply	other threads:[~2019-10-31 16:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  8:27 Olaf Hering
2019-10-31 10:15 ` SZEDER Gábor
2019-10-31 13:21   ` Olaf Hering
2019-10-31 16:56     ` SZEDER Gábor [this message]
2019-10-31 17:12       ` Eric Sunshine
2019-10-31 19:30   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191031165632.GA4348@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --subject='Re: git fsck, badDate: invalid author/committer line - bad date' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).