From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Emily Shaffer <emilyshaffer@google.com>, git@vger.kernel.org
Subject: Re: Should we auto-close PRs on git/git?
Date: Tue, 12 Nov 2019 20:10:20 -0500 [thread overview]
Message-ID: <20191113011020.GB20431@sigill.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1911121946480.46@tvgsbejvaqbjf.bet>
On Tue, Nov 12, 2019 at 08:11:06PM +0100, Johannes Schindelin wrote:
> > To that end, I wonder if we should add an Action to automatically
> > close PRs on that repo. It looks like
> > https://github.com/dessant/repo-lockdown would do the trick. We could
> > close incoming PRs automatically with a kind, maybe more succinct or
> > prescriptive version of the prefill text encouraging folks to open the
> > exact same PR against gitgitgadget/git instead.
>
> I am rather certain that that would not be a good thing to do.
>
> There are some people who open git/git PRs solely for the PR builds,
> others to facilitate code review, and yet others just because it is the
> intuitively obvious way to contribute to Git.
We talked a while ago about having GitGitGadget operate on git/git,
rather than on a separate mirror. That would automatically help at least
one class of PR-opener: people who want their patches to reach the list
but didn't realize they should be using gitgitgadget/git.
I don't remember what the technical blockers are for getting that set
up, but it seems like a strictly nicer outcome than auto-closing their
PR.
-Peff
next prev parent reply other threads:[~2019-11-13 1:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 2:00 Should we auto-close PRs on git/git? Emily Shaffer
2019-11-09 4:55 ` Junio C Hamano
2019-11-13 5:29 ` Stephen Smith
2019-11-12 19:11 ` Johannes Schindelin
2019-11-13 1:10 ` Jeff King [this message]
2019-11-13 12:04 ` Johannes Schindelin
2019-11-14 7:41 ` Jeff King
2019-11-14 23:03 ` Johannes Schindelin
2019-11-18 18:37 ` GitGitGadget on git/git, was " Johannes Schindelin
2019-11-21 10:54 ` Jeff King
2019-11-22 13:50 ` Johannes Schindelin
2019-11-22 14:43 ` Johannes Schindelin
2019-11-25 14:30 ` Jeff King
2019-11-26 20:55 ` Johannes Schindelin
2019-11-26 21:56 ` Eric Wong
2019-11-26 22:22 ` Johannes Schindelin
2019-11-26 22:40 ` Eric Wong
2019-11-26 22:52 ` Johannes Schindelin
2019-11-26 23:58 ` Eric Wong
2019-11-27 1:52 ` Junio C Hamano
2019-11-27 2:37 ` Eric Wong
2019-11-13 21:09 ` Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113011020.GB20431@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).