From: Aaron Schrab <aaron@schrab.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] wt-status: show amended content when verbose
Date: Tue, 19 Nov 2019 19:27:29 -0500 [thread overview]
Message-ID: <20191120002729.GG4444@pug.qqx.org> (raw)
In-Reply-To: <20191119145632.xi6zebglzu4lbgcq@yadavpratyush.com>
At 20:26 +0530 19 Nov 2019, Pratyush Yadav <me@yadavpratyush.com> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> > It too makes quite a lot of sense to allow readers to see what the
>> > 'amend' did, but that is not something that would help write the log
>> > message.
>
>It would help _amend_ the log message though.
Indeed. Another possible use is for sanity checking the amendment. I'll
often look over the diff in my editor as a final check of what I'm about
to commit, and when amending a commit I think I would find it helpful to
be able to review the changes being amended separately from the full set
of changes.
next prev parent reply other threads:[~2019-11-20 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 16:18 [RFC PATCH] wt-status: show amended content when verbose Pratyush Yadav
2019-11-18 3:36 ` Junio C Hamano
2019-11-18 4:02 ` Junio C Hamano
2019-11-19 14:56 ` Pratyush Yadav
2019-11-20 0:27 ` Aaron Schrab [this message]
2019-11-20 1:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120002729.GG4444@pug.qqx.org \
--to=aaron@schrab.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).