From: Emily Shaffer <emilyshaffer@google.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [RFC] Hook management via 'git hooks' command
Date: Mon, 25 Nov 2019 14:45:33 -0800 [thread overview]
Message-ID: <20191125224533.GB83137@google.com> (raw)
In-Reply-To: <20191125222113.GA83137@google.com>
> This sounds like we both are pretty close on the same page, so I think I
> will get started in the coming weeks and see if we can get a mockup to
> pick at with the implementation details in front of us.
Hm. To elaborate (and partially as a reminder to myself) I will try to
get it done in the following order:
1. Implement 'git hook list <hookname>' which reads all the configs.
(User would need to manually add the configs at this stage)
2. (maybe) Implement 'git hook execute <hookname> <arg...>'. This may or
may not be useful; I suppose it would be pretty equivalent to:
$ git hook list <hookname> | xargs -I% sh % <arg...>
3. Implement config modifiers like 'git hook add', 'git hook edit' etc.
My thinking is that we will have a lot of time with 1. in front of us to
nitpick how we want the config format to look, how the ordering should
go, etc. and it will be a fairly simple implementation. It'll also be
"usable" although not in a particularly friendly way in case someone
wants to try it and see, in a way that the config modifiers by
themselves wouldn't be.
- Emily
next prev parent reply other threads:[~2019-11-25 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 1:11 [RFC] Hook management via 'git hooks' command Emily Shaffer
2019-11-16 5:45 ` brian m. carlson
2019-11-18 22:38 ` Emily Shaffer
2019-11-19 0:51 ` brian m. carlson
2019-11-23 1:19 ` Emily Shaffer
2019-11-25 3:04 ` brian m. carlson
2019-11-25 22:21 ` Emily Shaffer
2019-11-25 22:45 ` Emily Shaffer [this message]
2019-11-26 0:28 ` brian m. carlson
2019-11-26 0:56 ` Emily Shaffer
2019-11-26 2:41 ` brian m. carlson
2019-12-02 23:46 ` Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125224533.GB83137@google.com \
--to=emilyshaffer@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).