From: Jonathan Nieder <jrnieder@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] contrib: git-cpcover: copy cover letter
Date: Tue, 3 Dec 2019 20:44:49 -0800 [thread overview]
Message-ID: <20191204044449.GB226135@google.com> (raw)
In-Reply-To: <20191203201233.661696-1-mst@redhat.com>
Hi,
Michael S. Tsirkin wrote:
> My flow looks like this:
> 1. git format-patch -v<n> --cover-letter <params> -o <dir>
> 2. vi <dir>/v<n-1>-0000-cover-letter.patch <dir>/v<n>-0000-cover-letter.patch
>
> copy subject and blurb, avoiding patchset stats
>
> 3. add changelog update blurb as appropriate
>
> 4. git send-email <dir>/v<n>-*
>
> The following perl script automates step 2 above.
Neat. I wonder, should "git format-patch" learn an option for this?
E.g.
git format-patch -v<n> --cover-letter \
--last-cover-letter=<dir>/v<n-1>-0000-cover-letter.patch \
-o <dir>
What would your ideal interface for this flow look like?
[...]
> Any feedback on this? Interest in taking this into contrib/ for now?
I don't know what Junio's preferences are for new contrib/
contributions, but I kind of like it. If putting it in contrib/, my
main advice would be to put it in a subdirectory there with a README.
That way, we have a good place to document what it was replaced by
once it has graduated to a standard format-patch feature.
Thanks and hope that helps,
Jonathan
next prev parent reply other threads:[~2019-12-04 4:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 20:13 [PATCH v2] contrib: git-cpcover: copy cover letter Michael S. Tsirkin
2019-12-04 4:44 ` Jonathan Nieder [this message]
2019-12-04 5:18 ` Eric Sunshine
2019-12-04 16:22 ` Junio C Hamano
2019-12-04 16:32 ` Eric Sunshine
2019-12-04 17:07 ` Junio C Hamano
2019-12-09 15:49 ` Michael S. Tsirkin
2019-12-04 6:58 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204044449.GB226135@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).