git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, johannes.schindelin@gmx.net,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] unpack-trees: correctly compute result count
Date: Fri, 10 Jan 2020 05:37:29 -0500	[thread overview]
Message-ID: <20200110103729.GA470836@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.520.git.1578621570180.gitgitgadget@gmail.com>

On Fri, Jan 10, 2020 at 01:59:30AM +0000, Derrick Stolee via GitGitGadget wrote:

>     Here is a very small fix to the cone-mode pattern-matching in
>     unpack-trees.c. Johannes found this while running a Coverity scan for
>     other issues. He alerted me to the problem and I could immediately see 
>     my error here. In creating this patch, most of my time was spent asking
>     "how did this work before?" and "why didn't this hurt performance?"
>     Hopefully my commit message explains this thoroughly enough.

Yes, it makes perfect sense (and as soon as I saw the explanation of the
problem, my immediate response was also "wait, how did this even work").

And the patch itself looks good.

>     As for making it into the release, I don't know. The change is small, it
>     has a very limited scope, but this flaw is also not really hurting
>     anything in a major way.

I could go either way.

This counts as something small and obvious enough that I'd consider
slipping it in at the last minute if it were fixing a bad bug. But given
how minor the bug is, being conservative makes sense to me, if only
because it's good to exercise our release discipline muscles. :)

-Peff

  reply	other threads:[~2020-01-10 10:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  1:59 [PATCH] unpack-trees: correctly compute result count Derrick Stolee via GitGitGadget
2020-01-10 10:37 ` Jeff King [this message]
2020-01-10 11:24   ` Derrick Stolee
2020-01-10 11:30     ` Derrick Stolee
2020-01-10 19:33   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110103729.GA470836@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).