From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] Makefile: use compat regex with SANITIZE=address
Date: Fri, 17 Jan 2020 23:39:31 +0000 [thread overview]
Message-ID: <20200117233931.GB6570@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20200117174931.GA8958@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
On 2020-01-17 at 17:49:31, Jeff King wrote:
> On Fri, Jan 17, 2020 at 09:37:22AM -0800, Junio C Hamano wrote:
>
> > Jeff King <peff@peff.net> writes:
> >
> > > Recent versions of the gcc and clang Address Sanitizer produce test
> > > failures related to regexec(). This triggers with gcc-10 and clang-8
> > > (but not gcc-9 nor clang-7). Running:
> > >
> > > make CC=gcc-10 SANITIZE=address test
> > >
> > > results in failures in t4018, t3206, and t4062.
> > [...]
> > I guess we should treat this the same way as the recent vcproj "fix"
> > by Dscho, i.e. fast-track to 'maint' to ensure that all public
> > integration branches has it soonish?
>
> I don't think there's a huge rush. It only triggers ASan and recent
> compilers, so AFAIK nobody has been hitting this in CI. I occasionally
> test with whatever is the most recent compiler in Debian unstable to see
> if it turns up any interesting new warnings or errors (but gcc-9 is
> still the default there).
I've reported this as a bug to Debian on the clang-8 and libasan6
packages, along with a trivial test case. Hopefully this will get fixed
soon.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2020-01-17 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:51 [PATCH] Makefile: use compat regex with SANITIZE=address Jeff King
2020-01-16 18:34 ` [PATCH] t4018: drop "debugging" cat from hunk-header tests Jeff King
2020-01-16 22:56 ` Jonathan Nieder
2020-01-17 17:37 ` [PATCH] Makefile: use compat regex with SANITIZE=address Junio C Hamano
2020-01-17 17:49 ` Jeff King
2020-01-17 23:39 ` brian m. carlson [this message]
2020-01-18 3:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117233931.GB6570@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).