From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C095C04EB5 for ; Fri, 7 Feb 2020 14:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E49B20720 for ; Fri, 7 Feb 2020 14:47:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RSKjn8Ii" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgBGOrb (ORCPT ); Fri, 7 Feb 2020 09:47:31 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36876 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGOrb (ORCPT ); Fri, 7 Feb 2020 09:47:31 -0500 Received: by mail-wm1-f67.google.com with SMTP id f129so3077402wmf.2 for ; Fri, 07 Feb 2020 06:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RbGfv//HPpa+bvJ09hBfk+EOWYGiijTalEHIYR/ipmY=; b=RSKjn8IilMq4+Bl/D42iuLmBIINOQh0GTfEF6BEGxLN2D5Br1OocopKJN3/s7SrQ5n +YT4nHzwh6KNth1kF184nHkOHg06Bx6GGapvTKGSRYk/kxWsya6MXpVfvXkVj76O7nmc 2aiIMG0n9xJjBfqmJ0Nn+7F2jHF6eHOxFYFGZOBfa+6m3WZrvbSAG2r+Pfb2ZV6/UnGQ ZERMjEmKZWT6zCQ70mR7qFHqRrMwK5fnpu/y5mdLNfA/rqwxsDIXxgSLqSTkJdxUz777 KAJpNGwHXadgn4lmslITZEwdVWxYdIqIjmtoyo5jNR1CZz7w88oS8g05xDxbT7hGseAH CVbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RbGfv//HPpa+bvJ09hBfk+EOWYGiijTalEHIYR/ipmY=; b=m+b+0CCior/My0PzsTJL/nQ1H9kxkdC/31sfQojTCLJirF6EIjlZsuLdm3mZokoiZN c9YlI8IO5ir/fhgzi4J0sLC65+Mf+T/lRp4ZrNzXW+FlLN6/gn+rhofjwvt+mOYdc3f7 YLB9VM9bVjVTxJcV4ZpjVMxek60OQkhEwD3qs7+3qfLMZT2eDvbJA2YMKGPHKfVHlgjR y+6edz11OU9P67yR+5xFnCQY7ob2zw95Ajc8NZ4kUl6Dqe7DXGb+1Pqm5dKBpo5wa4iy NbatxUPa1MpzCLoqqKqbOIZLZxzudKuuedwYlVNFGxt+vxdDuXfzSdhPTO9XQHfOurod t0rw== X-Gm-Message-State: APjAAAVWJb8Qjm/YEpOGdvoC2qJngFRgRJryBs4tFOTeVpMpAjxM2Jtr /rA4ixtnlc/hdW6PKfgziE8= X-Google-Smtp-Source: APXvYqzhWEyyXW1xGuBj9UWyQluF7DotOOM9Zv5WJkfpEGvF2M9joIMhc5MnWobRQ6d4bhSCJqmcfA== X-Received: by 2002:a7b:cf39:: with SMTP id m25mr4728473wmg.146.1581086848727; Fri, 07 Feb 2020 06:47:28 -0800 (PST) Received: from szeder.dev (x4db318d8.dyn.telefonica.de. [77.179.24.216]) by smtp.gmail.com with ESMTPSA id p11sm3773717wrn.40.2020.02.07.06.47.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Feb 2020 06:47:27 -0800 (PST) Date: Fri, 7 Feb 2020 15:47:25 +0100 From: SZEDER =?utf-8?B?R8OhYm9y?= To: Emily Shaffer Cc: git@vger.kernel.org Subject: Re: [PATCH v6 10/15] bugreport: add config values from safelist Message-ID: <20200207144725.GF2868@szeder.dev> References: <20200206004108.261317-1-emilyshaffer@google.com> <20200206004108.261317-11-emilyshaffer@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200206004108.261317-11-emilyshaffer@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Feb 05, 2020 at 04:41:03PM -0800, Emily Shaffer wrote: > +static void get_safelisted_config(struct strbuf *config_info) > +{ > + size_t idx; > + struct string_list_item *it = NULL; > + struct key_value_info *kv_info = NULL; > + > + for (idx = 0; idx < ARRAY_SIZE(bugreport_config_safelist); idx++) { GCC 9 complains about this loop condition: CC bugreport.o bugreport.c: In function 'get_safelisted_config': bugreport.c:66:20: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] 66 | for (idx = 0; idx < ARRAY_SIZE(bugreport_config_safelist); idx++) { | ^ I don't understand this error, that autogenerated 'bugreport_config_safelist' array clearly has a a non-zero size. What am I missing? > + const struct string_list *list = > + git_config_get_value_multi(bugreport_config_safelist[idx]); > + > + if (!list) > + continue; > + > + strbuf_addf(config_info, "%s:\n", bugreport_config_safelist[idx]); > + for_each_string_list_item(it, list) { > + kv_info = it->util; > + strbuf_addf(config_info, " %s (%s)\n", it->string, > + kv_info ? config_scope_name(kv_info->scope) > + : "source unknown"); > + } > + } > +} > +