From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
Parth Gala via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Parth Gala <parthpgala@gmail.com>
Subject: Re: [PATCH 2/5] object.c: lookup_unknown_object() accept 'r' as parameter
Date: Thu, 13 Feb 2020 13:52:35 -0500 [thread overview]
Message-ID: <20200213185235.GA15252@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqh7zus6hm.fsf@gitster-ct.c.googlers.com>
On Thu, Feb 13, 2020 at 10:10:45AM -0800, Junio C Hamano wrote:
> > Right, but my suggestion was that this advice doesn't apply to this
> > particular instance since I don't expect that we'd ever passing
> > something other than 'the_repository'.
> >
> > Specifically, I was worried that we'd get bitten by re-assigning 'r' in
> > the middle of the function and then end up in some odd broken state.
>
> "git fsck" works only in a single, "the", repository, so I guess you
> are right to be worried about unnecessary complexity here.
I think the end-game for this whole repository transition would be to
get rid of the_repository, though. I.e., I'd envision the progression
something like this:
1. Teach all of the library code to take (and operate on) "struct
repository".
2. Teach static local functions like this to pass in the_repository.
3. Teach top-level commands like cmd_fsck() to pass the_repository to
all of those static local helpers.
4. Teach top-level commands to get a real repository pointer, either
from the git.c wrapper (when RUN_SETUP is used) or by calling
setup_git_repository() themselves.
5. Grep for the_repository and drop it everywhere.
Here we're at step 2 now, but declaring "r" makes moving to step 3 just
a little easier. And I think the existence of steps 4 and 5 implies that
it would eventually be worth going through step 3.
Of course I just wrote those steps down for the first time, so maybe
nobody else shares my vision. ;)
-Peff
next prev parent reply other threads:[~2020-02-13 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 19:19 [PATCH 0/5] object.c: localize global the_repository variable into r Parth Gala via GitGitGadget
2020-02-12 19:19 ` [PATCH 1/5] object.c: get_max_object_index and get_indexed_object accept 'r' parameter Parth Gala via GitGitGadget
2020-02-12 20:22 ` Taylor Blau
2020-02-12 21:13 ` Eric Sunshine
2020-02-13 5:23 ` parth gala
2020-02-12 19:19 ` [PATCH 2/5] object.c: lookup_unknown_object() accept 'r' as parameter Parth Gala via GitGitGadget
2020-02-12 20:25 ` Taylor Blau
2020-02-12 21:11 ` Junio C Hamano
2020-02-13 18:00 ` Taylor Blau
2020-02-13 18:10 ` Junio C Hamano
2020-02-13 18:52 ` Jeff King [this message]
2020-02-15 0:00 ` Taylor Blau
2020-02-12 19:19 ` [PATCH 3/5] object.c: parse_object_or_die() " Parth Gala via GitGitGadget
2020-02-12 19:19 ` [PATCH 4/5] object.c: clear_object_flags() " Parth Gala via GitGitGadget
2020-02-12 19:19 ` [PATCH 5/5] object.c: clear_commit_marks_all() " Parth Gala via GitGitGadget
2020-02-12 20:18 ` [PATCH 0/5] object.c: localize global the_repository variable into r Taylor Blau
2020-02-13 5:14 ` parth gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213185235.GA15252@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=parthpgala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).