From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B8BC3404B for ; Tue, 18 Feb 2020 21:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A5D82173E for ; Tue, 18 Feb 2020 21:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727370AbgBRVXl (ORCPT ); Tue, 18 Feb 2020 16:23:41 -0500 Received: from cloud.peff.net ([104.130.231.41]:47284 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727354AbgBRVXk (ORCPT ); Tue, 18 Feb 2020 16:23:40 -0500 Received: (qmail 20419 invoked by uid 109); 18 Feb 2020 21:23:40 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 18 Feb 2020 21:23:40 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22668 invoked by uid 111); 18 Feb 2020 21:32:40 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 18 Feb 2020 16:32:40 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 18 Feb 2020 16:23:39 -0500 From: Jeff King To: Junio C Hamano Cc: Taylor Blau , git@vger.kernel.org Subject: Re: [PATCH v2 06/15] rev-list: make --count work with --objects Message-ID: <20200218212339.GC22630@coredump.intra.peff.net> References: <20200214182147.GA654525@coredump.intra.peff.net> <20200214182220.GF150965@coredump.intra.peff.net> <20200215004216.GA15192@syl.local> <20200215064818.GB1633703@coredump.intra.peff.net> <20200218052438.GB1641086@coredump.intra.peff.net> <20200218195531.GA21774@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Feb 18, 2020 at 01:19:51PM -0800, Junio C Hamano wrote: > >> /* > >> * The object count is always accumulated in the .count_right > >> * field for traversal that is not a left-right traversal, > >> * and cmd_rev_list() made sure that a .count request that > >> * wants to count non-commit objects, which is handled by > >> * the show_object() callback, does not ask for .left_right. > >> */ > >> > >> Overkill? I dunno. > > > > No, I think it looks good. Want to squash that in (and I'll do likewise > > locally)? > > It's too late for squashing anything in, as they are in 'next' > already. Ah, I hadn't noticed that yet. I can live without it, but I'd also be OK with a patch on top if you want to add it. -Peff