From: Danh Doan <congdanhqx@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] configure: respect --without-openssl
Date: Wed, 18 Mar 2020 18:34:39 +0700 [thread overview]
Message-ID: <20200318113439.GA29808@danh.dev> (raw)
In-Reply-To: <20200318112213.GB366567@camp.crustytoothpaste.net>
On 2020-03-18 11:22:13+0000, "brian m. carlson" <sandals@crustytoothpaste.net> wrote:
> On 2020-03-18 at 07:38:02, Đoàn Trần Công Danh wrote:
> > Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> > ---
> > configure.ac | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 7468eb6bc8..20a11e1f32 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -544,9 +544,15 @@ GIT_STASH_FLAGS($OPENSSLDIR)
> >
> > AC_CHECK_LIB([crypto], [SHA1_Init],
> > [NEEDS_SSL_WITH_CRYPTO=],
> > -[AC_CHECK_LIB([ssl], [SHA1_Init],
> > - [NEEDS_SSL_WITH_CRYPTO=YesPlease NO_OPENSSL=],
> > - [NEEDS_SSL_WITH_CRYPTO= NO_OPENSSL=YesPlease])])
> > +[
> > +if "x$NO_OPENSSL" = xYesPlease; then
> > + AC_MSG_ERROR([Disabled OpenSSL is required for SHA1])
>
> I don't see this in the original. Wouldn't we want to fall back to the
> default in this case, which would be SHA1DC?
This block of code will be run into in macOS only.
Really, I wasn't sure what should be done in this case (I mentioned in
the cover letter).
Should we set:
NEEDS_SSL_WITH_CRYPTO=
NO_OPENSSL=YesPlease
in this case instead?
--
Danh
next prev parent reply other threads:[~2020-03-18 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 7:36 [PATCH 0/3] configure: respect --without-<package> flags Đoàn Trần Công Danh
2020-03-18 7:38 ` [PATCH 1/3] configure: respect --without-curl flags Đoàn Trần Công Danh
2020-03-18 15:51 ` Eric Sunshine
2020-03-19 3:19 ` Danh Doan
2020-03-18 7:38 ` [PATCH 2/3] configure: respect --without-expat Đoàn Trần Công Danh
2020-03-18 7:38 ` [PATCH 3/3] configure: respect --without-openssl Đoàn Trần Công Danh
2020-03-18 11:22 ` brian m. carlson
2020-03-18 11:34 ` Danh Doan [this message]
2020-03-19 3:58 ` [PATCH v2 0/3] configure: respect --without-<package> flags Đoàn Trần Công Danh
2020-03-19 3:58 ` [PATCH v2 1/3] configure: respect --without-curl flag Đoàn Trần Công Danh
2020-03-19 3:58 ` [PATCH v2 2/3] configure: respect --without-expat flag Đoàn Trần Công Danh
2020-03-19 3:58 ` [PATCH v2 3/3] configure: respect --without-openssl flag Đoàn Trần Công Danh
2020-03-26 12:23 ` [PATCH v2 0/3] configure: respect --without-<package> flags Danh Doan
2020-03-27 18:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318113439.GA29808@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).