From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: git@vger.kernel.org
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: [PATCH v2 0/1] submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
Date: Wed, 18 Mar 2020 19:50:23 +0530 [thread overview]
Message-ID: <20200318142024.16681-1-shouryashukla.oo@gmail.com> (raw)
In-Reply-To: <20200318095842.27679-1-shouryashukla.oo@gmail.com>
Subcommands in 'submodule--helper.c' which give a callback to other functions
have structures and macros named in the format: 'subcommand_cb' and 'SUBCOMMAND_CB_INIT'
respectively.
The subcommand 'foreach' did not follow this convention and therefore had the naming of
the form: 'struct foreach_cb' and 'CB_FOREACH_INIT'. Rename these to: 'struct foreach_cb'
and 'FOREACH_CB_INIT' respectively.
Changes in v2:
Reworded the commit message. The last statement was wrong.
Changed it from:
"Rename the aforementioned structures and macros:
'struct foreach_cb' to 'struct cb_foreach' and 'CB_FOREACH_INIT'
to 'FOREACH_CB_INIT'."
;to:
"Rename the aforementioned structures and macros:
'struct cb_foreach' to 'struct foreach_cb' and 'CB_FOREACH_INIT'
to 'FOREACH_CB_INIT'."
Shourya Shukla (1):
submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
builtin/submodule--helper.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.20.1
next prev parent reply other threads:[~2020-03-18 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:58 [PATCH 0/1] submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb' Shourya Shukla
2020-03-18 9:58 ` [PATCH 1/1] " Shourya Shukla
2020-03-18 10:57 ` Derrick Stolee
2020-03-18 14:20 ` Shourya Shukla [this message]
2020-03-18 14:20 ` [PATCH v2 " Shourya Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318142024.16681-1-shouryashukla.oo@gmail.com \
--to=shouryashukla.oo@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).