From: Jeff King <email@example.com>
To: Derrick Stolee <firstname.lastname@example.org>
Cc: Christian Couder <email@example.com>,
Derrick Stolee via GitGitGadget <firstname.lastname@example.org>,
git <email@example.com>, Taylor Blau <firstname.lastname@example.org>,
Jonathan Tan <email@example.com>,
Jeff Hostetler <firstname.lastname@example.org>,
Derrick Stolee <email@example.com>
Subject: Re: [PATCH 0/2] Slightly simplify partial clone user experience
Date: Sun, 22 Mar 2020 15:22:34 -0400 [thread overview]
Message-ID: <20200322192234.GC671552@coredump.intra.peff.net> (raw)
On Sun, Mar 22, 2020 at 12:45:29PM -0400, Derrick Stolee wrote:
> >> I have mixed feelings on this. I do like making things less arcane for
> >> users. But are we locking in a behavior for --partial that we might not
> >> want to live with forever? I.e., the current thinking for partial clones
> >> is to fetch no blobs at all, get all commits and trees, apply sparse
> >> filters, and then fault in the blobs we need. But imagine we later grow
> >> the ability to easily avoid fetching all of the trees. Would we regret
> >> having the simple name "--partial" taken?
> > I agree with that. Something like "--filter-blobs" for
> > "--filter=blob:none" and perhaps "--filter-blobs=<size>" for
> > "--filter=blob:limit=<size>" might be worth it though.
> Thanks for the perspective on this. The --filter-blobs[=<size>] should
> be less likely to collide with an alternative definition of "partial".
Yes, though I wonder if it's really that big an improvement over
> While we are thinking in this space, what if we had a "partial-clone"
> builtin? It could be a light wrapper around "git clone" where
> git partial-clone [--limit=<size>] [options] <url> [<dir>]
> would do the same thing as
> git clone --filter=blob:[none|limit=<size>] [options] <url> [<dir>]
> Just spit-balling here.
I think that just shifts my concern out to the other command; i.e.,
would we later want the partial-clone command to behave differently.
And introducing a wrapper creates a weird non-orthogonality where it's
not necessary. I _do_ think a wrapper could make sense when it's doing
substantially different things, or multiple steps that don't belong in
the original program (e.g., the way Scalar works).
> In the meantime, I'll work to adjust my patches to only be the
> documentation of the --filter option.
Thanks, that seems like an obvious and easy improvement.
next prev parent reply other threads:[~2020-03-22 19:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 17:28 [PATCH 0/2] Slightly simplify partial clone user experience Derrick Stolee via GitGitGadget
2020-03-19 17:28 ` [PATCH 1/2] partial-clone: set default filter with --partial Derrick Stolee via GitGitGadget
2020-03-20 20:26 ` Junio C Hamano
2020-03-20 20:38 ` Derrick Stolee
2020-03-22 9:46 ` Jeff King
2020-03-19 17:28 ` [PATCH 2/2] clone: document --partial and --filter options Derrick Stolee via GitGitGadget
2020-03-20 12:27 ` [PATCH 0/2] Slightly simplify partial clone user experience Derrick Stolee
2020-03-22 9:51 ` Jeff King
2020-03-22 10:58 ` Christian Couder
2020-03-22 16:45 ` Derrick Stolee
2020-03-22 19:22 ` Jeff King [this message]
2020-03-22 16:03 ` Taylor Blau
2020-03-22 19:50 ` [PATCH v2] clone: document --filter options Derrick Stolee via GitGitGadget
2020-03-24 3:40 ` Jeff King
2020-03-24 5:17 ` Jonathan Nieder
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).