From: Emily Shaffer <emilyshaffer@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v10 5/5] bugreport: add compiler info
Date: Wed, 25 Mar 2020 14:10:24 -0700 [thread overview]
Message-ID: <20200325211024.GC53368@google.com> (raw)
In-Reply-To: <xmqqlfnq3bwc.fsf@gitster.c.googlers.com>
On Mon, Mar 23, 2020 at 04:10:59PM -0700, Junio C Hamano wrote:
> Emily Shaffer <emilyshaffer@google.com> writes:
>
> > +#ifdef _MSC_VER
> > + strbuf_addf(info, "MSVC version: %s\n", _MSC_FULL_VER);
> > +#endif
>
> This part is a bit different from what Dscho suggested to be
> squashed (and I have had on top of v9 series).
>
> Below is a diff between (v9 + SQUASH???) and v10. I think the
> change in the strftime format is a strict improvement.
Hmph. This is different than what I have in local. Please ignore this
entire v10, I've made a mistake in my tooling. I'm sorry about the
noise and for not checking over my patches better before mailing.
- Emily
next prev parent reply other threads:[~2020-03-25 21:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 21:43 [PATCH v10 0/5] add git-bugreport tool Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 1/5] help: move list_config_help to builtin/help Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 2/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 3/5] bugreport: gather git version and build info Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 4/5] bugreport: add uname info Emily Shaffer
2020-03-23 21:43 ` [PATCH v10 5/5] bugreport: add compiler info Emily Shaffer
2020-03-23 23:10 ` Junio C Hamano
2020-03-25 21:10 ` Emily Shaffer [this message]
2020-03-25 21:24 ` [PATCH v11 0/5] add git-bugreport tool Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 1/5] help: move list_config_help to builtin/help Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 2/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-04-01 20:17 ` SZEDER Gábor
2020-03-25 21:24 ` [PATCH v11 3/5] bugreport: gather git version and build info Emily Shaffer
2020-03-25 21:24 ` [PATCH v11 4/5] bugreport: add uname info Emily Shaffer
2020-03-25 21:25 ` [PATCH v11 5/5] bugreport: add compiler info Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 0/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 1/5] help: move list_config_help to builtin/help Emily Shaffer
2020-04-06 23:04 ` Junio C Hamano
2020-04-06 22:45 ` [PATCH v12 2/5] bugreport: add tool to generate debugging info Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 3/5] bugreport: gather git version and build info Emily Shaffer
2020-04-06 23:17 ` Junio C Hamano
2020-04-07 18:42 ` Emily Shaffer
2020-04-07 20:05 ` Junio C Hamano
2020-04-07 20:34 ` Emily Shaffer
2020-04-06 22:45 ` [PATCH v12 4/5] bugreport: add uname info Emily Shaffer
2020-04-06 23:20 ` Junio C Hamano
2020-04-06 22:45 ` [PATCH v12 5/5] bugreport: add compiler info Emily Shaffer
2020-04-06 23:31 ` Junio C Hamano
2020-04-06 23:47 ` Danh Doan
2020-04-07 15:09 ` Junio C Hamano
2020-04-07 18:35 ` Emily Shaffer
2020-04-07 15:24 ` [PATCH v12 0/5] bugreport: add tool to generate debugging info Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325211024.GC53368@google.com \
--to=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).