From: Denton Liu <liu.denton@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] t/lib-credential.sh: drop shebang line
Date: Thu, 26 Mar 2020 04:33:46 -0400 [thread overview]
Message-ID: <20200326083346.GA1891350@generichostname> (raw)
In-Reply-To: <20200326082527.GA3611762@coredump.intra.peff.net>
On Thu, Mar 26, 2020 at 04:25:27AM -0400, Jeff King wrote:
> The purpose of lib-credential.sh is to be sourced into other test
> scripts. It doesn't need a "#!/bin/sh" line, as running it directly
> makes no sense. Nor does it serve any real filetype documentation
> purpose, as the file is cleary named with a ".sh" extension.
s/cleary/clearly/
Patch and message look obviously good otherwise.
next prev parent reply other threads:[~2020-03-26 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 8:23 [PATCH 0/2] test shell-library cleanups Jeff King
2020-03-26 8:25 ` [PATCH 1/2] t/lib-credential.sh: drop shebang line Jeff King
2020-03-26 8:33 ` Denton Liu [this message]
2020-03-26 8:25 ` [PATCH 2/2] t/lib-*.sh: drop executable bit Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326083346.GA1891350@generichostname \
--to=liu.denton@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).