From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] fetch-pack: lazy fetch using tree:0
Date: Fri, 27 Mar 2020 05:37:10 -0400 [thread overview]
Message-ID: <20200327093710.GA611304@coredump.intra.peff.net> (raw)
In-Reply-To: <20200326195058.GA8613@syl.local>
On Thu, Mar 26, 2020 at 01:50:58PM -0600, Taylor Blau wrote:
> > One side note (for Taylor, cc'd): our patches elsewhere to limit the
> > allowed filters don't make it possible to express the difference between
> > "tree:0" and "tree:1". It may be worth thinking about that, especially
> > if it influences the config schema (since we'll have to support it
> > forever once it makes it into a release).
> [...]
> [uploadpack "filter.tree:depth"]
> allow = true
> maxDepth = <n>
Yeah, that scheme solves the problem very neatly, and removes any worry
I had about painting ourselves into a corner. Thanks.
-Peff
prev parent reply other threads:[~2020-03-27 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 17:44 [RFC PATCH] fetch-pack: lazy fetch using tree:0 Jonathan Tan
2020-03-19 19:58 ` Derrick Stolee
2020-03-20 6:12 ` Jeff King
2020-03-26 19:50 ` Taylor Blau
2020-03-27 9:37 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327093710.GA611304@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).