git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/6] Doc: drop support for docbook-xsl before 1.74
Date: Mon, 30 Mar 2020 05:45:13 -0400	[thread overview]
Message-ID: <20200330094513.GB1735224@coredump.intra.peff.net> (raw)
In-Reply-To: <cover.1585486103.git.martin.agren@gmail.com>

On Sun, Mar 29, 2020 at 03:18:04PM +0200, Martin Ågren wrote:

> In the documentation Makefile and a few helper conf and xsl files, we
> carry various workarounds to make the docs build at all or to look
> better with older docbook-xsl versions. Let's see if we can't just drop
> that support. All of this seems to have been useful at one point, but I
> doubt that anyone needs this nowadays. This was also suggested in [1].

Yay, I'm very happy to see this series. I'd be happy to go even further
if there's some benefit, but I think this removes the last of the
Makefile knobs.

Thanks for splitting each version bump into its own patch. That made it
a lot easier to see what we we're gaining from each one.

I double-checked that there's no difference with doc-diff when using a
modern asciidoc/docbook combo, though I'm sure you did as well.

> After this series, user-manual.conf still refers to older docbook-xsl
> versions. The proper fix there might be to actually be a bit more
> aggressive and drop that hunk, making the rendered docs prettier.
> There's some history there, including mentions of texinfo, which is
> outside my comfort zone. I've got work in progress there, but I'd rather
> submit that separately from these "expected no-op" patches.

Yeah, dropping that bit from user-manual.conf seems reasonable. That
shouldn't show anything in doc-diff because it's not installed with the
manpages. And the HTML build wouldn't use docbook. I installed the
zillion packages needed to build user-manual.pdf. The behavior without
that block looks significantly nicer (the example blocks are actually
shaded).

The very first example block in section 1.1 has some funny indentation,
but that's true before or after.

Anyway, that was just for my own curiosity. If you've got further work
in that area and prefer to do it as a separate series, that's fine by
me.

-Peff

  parent reply	other threads:[~2020-03-30  9:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29 13:18 Martin Ågren
2020-03-29 13:18 ` [PATCH 1/6] Doc: drop support for docbook-xsl before 1.71.1 Martin Ågren
2020-03-29 13:18 ` [PATCH 2/6] Doc: drop support for docbook-xsl before 1.72.0 Martin Ågren
2020-03-29 13:18 ` [PATCH 3/6] Doc: drop support for docbook-xsl before 1.73.0 Martin Ågren
2020-03-29 13:18 ` [PATCH 4/6] manpage-bold-literal.xsl: stop using git.docbook.backslash Martin Ågren
2020-03-29 13:18 ` [PATCH 5/6] manpage-normal.xsl: fold in manpage-base.xsl Martin Ågren
2020-03-29 13:18 ` [PATCH 6/6] INSTALL: drop support for docbook-xsl before 1.74 Martin Ågren
2020-03-30  9:26   ` Jeff King
2020-03-29 16:27 ` [PATCH 0/6] Doc: " Junio C Hamano
2020-03-30  9:45 ` Jeff King [this message]
2020-03-31 19:26   ` Martin Ågren
2020-04-01 10:17     ` Jeff King
2020-04-01 16:59       ` Junio C Hamano
2020-04-02  0:45       ` brian m. carlson
2020-04-02 16:48         ` Junio C Hamano
2020-03-30 10:46 ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330094513.GB1735224@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --subject='Re: [PATCH 0/6] Doc: drop support for docbook-xsl before 1.74' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox