From: Jiang Xin <worldhello.net@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Cc: xuejiang <xuejiang@alibaba-inc.com>,
Jiang Xin <worldhello.net@gmail.com>
Subject: [PATCH] git-submodule.sh: setup uninitialized variables
Date: Thu, 2 Apr 2020 16:42:51 +0800 [thread overview]
Message-ID: <20200402084251.85840-1-zhiyou.jx@alibaba-inc.com> (raw)
From: xuejiang <xuejiang@alibaba-inc.com>
We have an environment variable `jobs=16` defined in our CI system, and
this environment makes our build job failed with the following message:
error: pathspec '16' did not match any file(s) known to git
The pathspect '16' for Git command is from the environment variable
"jobs".
This is because "git-submodule" command is implemented in shell script,
and environment variables may change its behavior. Set values for
uninitialized variables, such as "jobs" and "recommend_shallow" will
fix this issue.
Helped-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Li Xuejiang <xuejiang@alibaba-inc.com>
---
git-submodule.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/git-submodule.sh b/git-submodule.sh
index 1cb2c0a31b..d69d24a857 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -43,6 +43,8 @@ custom_name=
depth=
progress=
dissociate=
+jobs=
+recommend_shallow=
die_if_unmatched ()
{
--
2.20.1.7.g153144c
next reply other threads:[~2020-04-02 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 8:42 Jiang Xin [this message]
2020-04-02 15:11 ` [PATCH] git-submodule.sh: setup uninitialized variables Eric Sunshine
2020-04-03 2:56 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402084251.85840-1-zhiyou.jx@alibaba-inc.com \
--to=worldhello.net@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=xuejiang@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).