From: Emma Brooks <me@pluvano.com>
To: Danh Doan <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, Denton Liu <liu.denton@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] format-patch: teach --no-q-encode-headers
Date: Wed, 8 Apr 2020 03:57:20 +0000 [thread overview]
Message-ID: <20200408035720.GA25740@pluvano.com> (raw)
In-Reply-To: <20200407074031.GA20612@danh.dev>
On 2020-04-07 14:40:31+0700, Danh Doan wrote:
> > +format.qEncodeHeaders::
> > + Encode email headers that have non-ASCII characters with
> > + "Q-encoding" for email transmission. Defaults to true.
>
> I think have (described in RFC 2047) as same as
> --[no]-q-encode-headers belows would be better.
Agreed. I will reference it there as well.
> > +--q-encode-headers::
> > +--no-q-encode-headers::
> > + Encode email headers that have non-ASCII characters with
> > + "Q-encoding" (described in RFC 2047), instead of outputting the
> > + headers verbatim. The default is set to the value of the
> > + `format.qEncodeHeaders` configuration variable.
>
> I find this paragraph hard to understand.
> I think:
>
> If this option is omited, set to value of of ...
>
> is easier to understand (to me, at least).
OK, I will simplify the language in v3.
next prev parent reply other threads:[~2020-04-08 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 23:11 [PATCH] format-patch: teach --no-encode-headers Emma Brooks
2020-04-06 3:04 ` brian m. carlson
2020-04-06 13:30 ` Jeff King
2020-04-06 15:17 ` brian m. carlson
2020-04-06 15:30 ` Jeff King
2020-04-06 3:29 ` Junio C Hamano
2020-04-07 3:46 ` Emma Brooks
2020-04-07 19:37 ` Junio C Hamano
2020-04-07 20:31 ` Jeff King
2020-04-07 22:20 ` Junio C Hamano
2020-04-08 4:08 ` Emma Brooks
2020-04-07 5:17 ` [PATCH v2] format-patch: teach --no-q-encode-headers Emma Brooks
2020-04-07 7:40 ` Danh Doan
2020-04-08 3:57 ` Emma Brooks [this message]
2020-04-08 4:31 ` [PATCH v3] format-patch: teach --no-encode-email-headers Emma Brooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408035720.GA25740@pluvano.com \
--to=me@pluvano.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).