git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Sergey Organov <sorganov@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>, Ivan Tham <pickfire@riseup.net>,
	git@vger.kernel.org,
	"brian m . carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] branch: add '-' to delete previous branch
Date: Wed, 29 Apr 2020 13:57:45 -0600	[thread overview]
Message-ID: <20200429195745.GC3920@syl.local> (raw)
In-Reply-To: <87v9likr5a.fsf@osv.gnss.ru>

On Wed, Apr 29, 2020 at 10:50:41PM +0300, Sergey Organov wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> [...]
>
> > In my opinion, it is fairly clear that 'git branch -D -' means "delete
> > the last branch", and not "delete a list of branches from stdin.
>
> Honestly, I'd never guess it'd "delete the last branch". No way.

I'm having trouble understanding why. This is how 'git checkout -'
behaves, so I have no idea why 'git branch' wouldn't work the same way.

> "-" standing by itself in a command means stdin, stdout, or otherwise a
> typo. Using it for any other meaning is a blasphemy. Sure, nobody will
> die because of this, but it's /extremely/ confusing!

Again, not sure that this is always the case. This *is* how 'git
checkout' works.

> BTW, what about mistyping:
>
> $ git branch -d - f my_branch
>
> for
>
> $ git branch -d -f my_branch
>
> or some such?
>
> No, it still doesn't look like a good idea to use isolated '-' as
> suggested by the patch.

Frankly, I do not find this compelling. Does that mean that '/' as a
directory separator is dangerous, too, because you can accidentally
write 'rm -rf / foo/bar/baz'?

> OTOH, for otherwise unusual @{-1}, @{-}, or @- I'd immediately realize I
> must consult the manual, so these would be fine with me.
>
> Thanks,
> -- Sergey

Thanks,
Taylor

  reply	other threads:[~2020-04-29 19:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 13:01 [PATCH] branch: add '-' to delete previous branch Ivan Tham
2020-04-29 13:37 ` Sergey Organov
2020-04-29 19:00   ` Taylor Blau
2020-04-29 19:06     ` Eric Sunshine
2020-04-29 19:50     ` Sergey Organov
2020-04-29 19:57       ` Taylor Blau [this message]
2020-04-29 20:22         ` Junio C Hamano
2020-04-29 20:35           ` Taylor Blau
2020-04-29 20:39             ` Junio C Hamano
2020-04-29 20:37           ` Junio C Hamano
2020-04-29 20:26         ` Sergey Organov
2020-04-30 16:27           ` Konstantin Khomoutov
2020-04-30 19:52             ` Junio C Hamano
2020-05-01  9:18               ` Sergey Organov
2020-05-01  9:44                 ` Konstantin Khomoutov
2020-05-01 10:22                   ` Sergey Organov
2020-05-01 22:22                     ` Taylor Blau
2020-04-30  3:43       ` Ivan Tham
2020-04-29 19:27   ` Junio C Hamano
2020-04-29 19:31     ` Randall S. Becker
2020-04-29 19:55     ` Sergey Organov
2020-04-29 18:58 ` Taylor Blau
2020-04-30 14:52   ` Ivan Tham
2020-04-30 15:59     ` Taylor Blau
2020-04-30 19:51       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429195745.GC3920@syl.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=pickfire@riseup.net \
    --cc=sandals@crustytoothpaste.net \
    --cc=sorganov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).