From: Danh Doan <congdanhqx@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, clime <clime7@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] CodingGuidelines: drop arithmetic expansion advice to use "$x"
Date: Tue, 5 May 2020 06:32:55 +0700 [thread overview]
Message-ID: <20200504233255.GC29599@danh.dev> (raw)
In-Reply-To: <20200504160709.GB12842@coredump.intra.peff.net>
On 2020-05-04 12:07:09-0400, Jeff King <peff@peff.net> wrote:
> On Mon, May 04, 2020 at 08:37:38AM -0700, Junio C Hamano wrote:
>
> Subject: CodingGuidelines: drop arithmetic expansion advice to use "$x"
>
> The advice to use "$x" rather than "x" in arithmetric expansion was
> working around a dash bug fixed in 0.5.4. Even Debian oldstable has
> 0.5.7 these days. And in the meantime, we've added almost two dozen
> instances of the "x" form which you can find with:
>
> git grep '$(([a-z]'
>
> and nobody seems to have complained. Let's declare this workaround
> obsolete and simplify our style guide.
>
> Helped-by: Danh Doan <congdanhqx@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
I see this patch hasn't been merged to pu yet.
Please have my name as (if it's not too much trouble for you):
Đoàn Trần Công Danh <congdanhqx@gmail.com>
(I'm going to change my name in email setting)
--
Danh
next prev parent reply other threads:[~2020-05-04 23:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 20:31 git for-each-ref - sorting by multiple keys clime
2020-05-03 9:09 ` Jeff King
2020-05-03 9:11 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Jeff King
2020-05-03 11:44 ` Danh Doan
2020-05-04 15:13 ` Jeff King
2020-05-04 15:37 ` Junio C Hamano
2020-05-04 16:07 ` [PATCH] CodingGuidelines: drop arithmetic expansion advice to use "$x" Jeff King
2020-05-04 16:28 ` Carlo Marcelo Arenas Belón
2020-05-04 16:33 ` Jeff King
2020-05-04 19:47 ` Junio C Hamano
2020-05-04 23:32 ` Danh Doan [this message]
2020-05-05 20:40 ` Junio C Hamano
2020-05-05 21:07 ` Jeff King
2020-05-05 21:30 ` Junio C Hamano
2020-05-04 21:00 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Junio C Hamano
2020-05-05 0:11 ` Jeff King
2020-05-05 0:13 ` Taylor Blau
2020-05-03 9:13 ` [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts Jeff King
2020-05-04 21:05 ` Junio C Hamano
2020-05-05 0:14 ` Taylor Blau
2020-05-03 10:16 ` git for-each-ref - sorting by multiple keys clime
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504233255.GC29599@danh.dev \
--to=congdanhqx@gmail.com \
--cc=clime7@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).