From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christopher Warrington via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Christopher Warrington <chwarr@microsoft.com>
Subject: Re: [PATCH] bisect: fix replay of CRLF logs
Date: Fri, 8 May 2020 09:08:31 -0400 [thread overview]
Message-ID: <20200508130831.GB631018@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq5zd72vjp.fsf@gitster.c.googlers.com>
On Thu, May 07, 2020 at 04:07:54PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > The simplest fix is probably to clean up "$file" into another tempfile,
> > and then read from that.
>
> Or just tell the users do not break the log file (or they can keep
> both halves)?
I am OK with that, too. :)
-Peff
next prev parent reply other threads:[~2020-05-08 13:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:29 [PATCH] bisect: fix replay of CRLF logs Christopher Warrington via GitGitGadget
2020-05-07 22:13 ` Eric Sunshine
2020-05-07 22:25 ` Jeff King
2020-05-07 23:07 ` Junio C Hamano
2020-05-08 13:08 ` Jeff King [this message]
2020-05-08 15:07 ` Junio C Hamano
2020-05-08 16:28 ` Junio C Hamano
2020-05-08 17:12 ` Jeff King
2020-05-08 17:53 ` Junio C Hamano
2020-05-09 22:17 ` brian m. carlson
2020-05-10 10:54 ` Achim Gratz
2020-05-08 22:59 ` [EXTERNAL] " Christopher Warrington (CHRISTOPHER)
2020-05-09 16:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508130831.GB631018@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=chwarr@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).