From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E8AC433DF for ; Fri, 15 May 2020 18:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5859206D8 for ; Fri, 15 May 2020 18:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726278AbgEOSDS (ORCPT ); Fri, 15 May 2020 14:03:18 -0400 Received: from cloud.peff.net ([104.130.231.41]:47824 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726023AbgEOSDS (ORCPT ); Fri, 15 May 2020 14:03:18 -0400 Received: (qmail 25693 invoked by uid 109); 15 May 2020 18:03:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 15 May 2020 18:03:18 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 13906 invoked by uid 111); 15 May 2020 18:03:18 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 15 May 2020 14:03:18 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 15 May 2020 14:03:16 -0400 From: Jeff King To: Christian Couder Cc: git@vger.kernel.org, Junio C Hamano , Derrick Stolee , Taylor Blau , Jonathan Tan , Jonathan Nieder , Christian Couder Subject: Re: [PATCH 01/13] upload-pack: remove unused 'wants' from upload_pack_data Message-ID: <20200515180316.GA3692649@coredump.intra.peff.net> References: <20200515100454.14486-1-chriscool@tuxfamily.org> <20200515100454.14486-2-chriscool@tuxfamily.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200515100454.14486-2-chriscool@tuxfamily.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, May 15, 2020 at 12:04:42PM +0200, Christian Couder wrote: > As we cleanup 'upload-pack.c' by using 'struct upload_pack_data' > more thoroughly, let's remove 'struct object_array wants' from > 'struct upload_pack_data', as it appears to be unused. Yep, the diff shows this is clearly not used. I was a bit curious how it came to be unused, but it was like this from the very start of that struct being added in 3145ea957d (upload-pack: introduce fetch server command, 2018-03-15). We don't need it because of the local want_obj in upload_pack_v2(), but I see you deal with that in the next commit. Looks good so far. -Peff