From: Denton Liu <liu.denton@gmail.com>
To: Jiuyang Xie <jiuyangxie@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>
Subject: Re: [PATCH] doc: fix wrong 4-byte length of pkt-line message
Date: Thu, 21 May 2020 05:44:54 -0400 [thread overview]
Message-ID: <20200521094454.GA577071@generichostname> (raw)
In-Reply-To: <20200521075643.35286-1-jiuyang.xjy@alibaba-inc.com>
Hi Jiuyang,
On Thu, May 21, 2020 at 03:56:43PM +0800, Jiuyang Xie wrote:
> The first four bytes of the line, the pkt-len, indicates the total
> length of the pkt-line in hexadecimal. Fixed wrong pkt-len headers of
s/Fixed/Fix/ perhaps?
> some pkt-line messages in `http-protocol.txt` and `pack-protocol.txt`.
>
> Signed-off-by: Jiuyang Xie <jiuyang.xjy@alibaba-inc.com>
Aside from the above, I manually checked all of the changes and they
look good to me.
-Denton
next prev parent reply other threads:[~2020-05-21 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 7:56 [PATCH] doc: fix wrong 4-byte length of pkt-line message Jiuyang Xie
2020-05-21 9:44 ` Denton Liu [this message]
2020-05-21 10:41 ` [PATCH v2] " Jiuyang Xie
2020-05-21 11:21 ` Denton Liu
2020-05-21 11:32 ` [PATCH v3] " Jiuyang Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521094454.GA577071@generichostname \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jiuyang.xjy@alibaba-inc.com \
--cc=jiuyangxie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).