From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Toon Claes <toon@iotcl.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] Documentation: correct hash environment variable
Date: Mon, 25 May 2020 17:57:58 +0000 [thread overview]
Message-ID: <20200525175758.GE1915090@camp.crustytoothpaste.net> (raw)
In-Reply-To: <CAN0heSoyxvTTaJaRmnQADTaMrWa4QBbGnXi8MUZp7ksibejc8g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On 2020-05-25 at 16:42:57, Martin Ågren wrote:
> > -`GIT_DEFAULT_HASH_ALGORITHM`::
> > +`GIT_DEFAULT_HASH`::
> > If this variable is set, the default hash algorithm for new
> > repositories will be set to this value. This value is currently
> > ignored when cloning; the setting of the remote repository
>
> Indeed. This discrepancy is visible in the commit which added both the
> documentation and the implementation, 3c9331a129 ("builtin/init-db: add
> environment variable for new repo hash", 2020-02-22). As
> developers-only as this variable is, that commit was not in v2.26.0, so
> this might be worth fixing before cutting v2.27.0.
Yeah, thanks for catching this. I think this is worth fixing. It
doesn't do anything right now except produce an error, but we might as
well not mislead people.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2020-05-25 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 14:41 [PATCH 0/1] Documentation fix related to hash algorithm Toon Claes
2020-05-25 14:41 ` [PATCH 1/1] Documentation: correct hash environment variable Toon Claes
2020-05-25 16:42 ` Martin Ågren
2020-05-25 17:57 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525175758.GE1915090@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).