git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	git@vger.kernel.org, hji@dyntopia.com
Subject: Re: [PATCH] t: avoid alternation (not POSIX) in grep's BRE
Date: Thu, 28 May 2020 12:52:45 -0400	[thread overview]
Message-ID: <20200528165245.GA1223396@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqh7w03vnq.fsf@gitster.c.googlers.com>

On Thu, May 28, 2020 at 08:51:21AM -0700, Junio C Hamano wrote:

> > I think it may be a good policy to stick to the
> > simplest machine-readable formats for trailers. Likewise I'd suggest
> > using the full sha1-hex for future-proofing in this context.
> 
> Yes, or just roll it into prose like we often do.  Anybody can spot
> many examples from "git log --no-merges" ;-)

Yeah, I was sort of working under the assumption that people found
utility in putting that data in a trailer (in which case I'd really
suggest doing both; a prose one with subject meant for readers, and a
machine-readable annotation).

But I haven't really found a use for "Fixes" in machine-readable format.
I don't _mind_ people doing it if they do have a use (and I'd even
consider doing it myself if I were shown that it was useful). In the
meantime, I don't know if we want to state a project preference against
it.

-Peff

  reply	other threads:[~2020-05-28 16:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  8:37 [PATCH] t: avoid alternation (not POSIX) in grep's BRE Carlo Marcelo Arenas Belón
2020-05-28 15:20 ` Junio C Hamano
2020-05-28 15:43   ` Jeff King
2020-05-28 15:51     ` Junio C Hamano
2020-05-28 16:52       ` Jeff King [this message]
2020-05-28 19:20         ` Junio C Hamano
2020-05-28 20:35           ` Jeff King
2020-05-29  3:18             ` digging into historical commit references Jeff King
2020-05-29  3:39 ` [PATCH] t: avoid alternation (not POSIX) in grep's BRE Torsten Bögershausen
2020-05-29  8:20 ` [PATCH v2] " Carlo Marcelo Arenas Belón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528165245.GA1223396@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hji@dyntopia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).