git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Derrick Stolee <dstolee@microsoft.com>, Jeff King <peff@peff.net>,
	Taylor Blau <me@ttaylorr.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH v2 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 2
Date: Tue,  2 Jun 2020 06:16:44 +0200	[thread overview]
Message-ID: <20200602041657.7132-1-chriscool@tuxfamily.org> (raw)
In-Reply-To: <20200527164742.23067-1-chriscool@tuxfamily.org>

This patch series is the second part of an effort to move all static
variables in 'upload-pack.c' into 'struct upload_pack_data'.

It is based on 'cc/upload-pack-data' which contains "part 1" of this
effort. (See also: https://lore.kernel.org/git/20200515100454.14486-1-chriscool@tuxfamily.org/)

A part 3 will follow with the rest of the patches needed to get rid of
the static variables left after this patch series.

Thanks to Peff for his review of the first version (V1:
https://lore.kernel.org/git/20200527164742.23067-1-chriscool@tuxfamily.org/)
of this part 2.

Compared to V1 the changes are the following:

  - added patch 2/13 "upload-pack: annotate upload_pack_data fields"
    to add 'v0 only' or 'v2 only' comments to the 'upload_pack_data'
    fields, and to better group 'v0 only' and 'v2 only' fields
    together

  - added similar comments in all the other patches when necessary

  - in patch 3/13 'timeout' is still an 'unsigned int' after being
    moved into 'upload_pack_data'

  - in patch 10/13 commit message has been corrected to say that
    'allow_filter' is used by both protocol v0 and v2

  - in patch 11/13 commit message has been corrected to say that
    'allow_ref_in_want' is used only by protocol v2

Here is the range-diff with V1:

 1:  e5c31f30ec =  1:  e5c31f30ec upload-pack: actually use some upload_pack_data bitfields
 -:  ---------- >  2:  225be644f4 upload-pack: annotate upload_pack_data fields
 2:  5f2da66cfd !  3:  5adca8d70c upload-pack: move static vars to upload_pack_data
    @@ upload-pack.c: static int daemon_mode;
      /* 0 for no sideband,
       * otherwise maximum packet size (up to 65520 bytes).
     @@ upload-pack.c: struct upload_pack_data {
    -   timestamp_t deepen_since;
        int deepen_rev_list;
        int deepen_relative;
    -+  int timeout;
      
    ++  unsigned int timeout;                                   /* v0 only */
    ++
        struct list_objects_filter_options filter_options;
      
        struct packet_writer writer;
      
    -   unsigned stateless_rpc : 1;
    -+  unsigned daemon_mode : 1;
    +   unsigned stateless_rpc : 1;                             /* v0 only */
    ++  unsigned no_done : 1;                                   /* v0 only */
    ++  unsigned daemon_mode : 1;                               /* v0 only */
      
        unsigned use_thin_pack : 1;
        unsigned use_ofs_delta : 1;
    -   unsigned no_progress : 1;
    -   unsigned use_include_tag : 1;
    -   unsigned done : 1;
    -+  unsigned no_done : 1;
    - };
    - 
    - static void upload_pack_data_init(struct upload_pack_data *data)
     @@ upload-pack.c: static void upload_pack_data_clear(struct upload_pack_data *data)
        list_objects_filter_release(&data->filter_options);
      }
      
     -static void reset_timeout(void)
    -+static void reset_timeout(int timeout)
    ++static void reset_timeout(unsigned int timeout)
      {
        alarm(timeout);
      }
 3:  56b90f8b5d !  4:  1507a8134a upload-pack: move use_sideband to upload_pack_data
    @@ upload-pack.c: static unsigned int allow_unadvertised_object_request;
      
      static int filter_capability_requested;
     @@ upload-pack.c: struct upload_pack_data {
    -   int deepen_relative;
    -   int timeout;
    + 
    +   unsigned int timeout;                                   /* v0 only */
      
     +  /* 0 for no sideband, otherwise DEFAULT_PACKET_MAX or LARGE_PACKET_MAX */
     +  int use_sideband;
    @@ upload-pack.c: struct upload_pack_data {
        struct list_objects_filter_options filter_options;
      
        struct packet_writer writer;
    -@@ upload-pack.c: static void reset_timeout(int timeout)
    +@@ upload-pack.c: static void reset_timeout(unsigned int timeout)
        alarm(timeout);
      }
      
 4:  a49469bc06 !  5:  0ef8d28958 upload-pack: move filter_capability_requested to upload_pack_data
    @@ upload-pack.c: static struct object_array extra_edge_obj;
      static int allow_ref_in_want;
      
     @@ upload-pack.c: struct upload_pack_data {
    -   unsigned use_include_tag : 1;
    -   unsigned done : 1;
    -   unsigned no_done : 1;
    -+  unsigned filter_capability_requested : 1;
    - };
    +   unsigned stateless_rpc : 1;                             /* v0 only */
    +   unsigned no_done : 1;                                   /* v0 only */
    +   unsigned daemon_mode : 1;                               /* v0 only */
    ++  unsigned filter_capability_requested : 1;               /* v0 only */
      
    - static void upload_pack_data_init(struct upload_pack_data *data)
    +   unsigned use_thin_pack : 1;
    +   unsigned use_ofs_delta : 1;
     @@ upload-pack.c: static void receive_needs(struct upload_pack_data *data,
                        continue;
      
 5:  e0d720aa97 !  6:  319c09ce02 upload-pack: move multi_ack to upload_pack_data
    @@ upload-pack.c
      #define ALLOW_TIP_SHA1    01
      /* Allow request of a sha1 if it is reachable from a ref (possibly hidden ref). */
     @@ upload-pack.c: struct upload_pack_data {
    -   int deepen_rev_list;
        int deepen_relative;
    -   int timeout;
    -+  int multi_ack;
    + 
    +   unsigned int timeout;                                   /* v0 only */
    ++  int multi_ack;                                          /* v0 only */
      
        /* 0 for no sideband, otherwise DEFAULT_PACKET_MAX or LARGE_PACKET_MAX */
        int use_sideband;
 6:  076f4ad903 !  7:  cd3a0a1e5c upload-pack: change multi_ack to an enum
    @@ Commit message
     
      ## upload-pack.c ##
     @@ upload-pack.c: struct upload_pack_data {
    -   int deepen_rev_list;
        int deepen_relative;
    -   int timeout;
    --  int multi_ack;
    -+
    + 
    +   unsigned int timeout;                                   /* v0 only */
    +-  int multi_ack;                                          /* v0 only */
     +  enum  {
     +          no_multi_ack = 0,
     +          multi_ack = 1,
     +          multi_ack_detailed = 2
    -+  } multi_ack;
    ++  } multi_ack;                                            /* v0 only */
      
        /* 0 for no sideband, otherwise DEFAULT_PACKET_MAX or LARGE_PACKET_MAX */
        int use_sideband;
 7:  c0b051f344 =  8:  c23e37a8da upload-pack: pass upload_pack_data to upload_pack_config()
 8:  5daacc6670 !  9:  26893a4098 upload-pack: move keepalive to upload_pack_data
    @@ upload-pack.c: static timestamp_t oldest_have;
      
      static int allow_filter;
     @@ upload-pack.c: struct upload_pack_data {
    +   timestamp_t deepen_since;
        int deepen_rev_list;
        int deepen_relative;
    -   int timeout;
     +  int keepalive;
      
    +   unsigned int timeout;                                   /* v0 only */
        enum  {
    -           no_multi_ack = 0,
     @@ upload-pack.c: static void upload_pack_data_init(struct upload_pack_data *data)
        data->shallows = shallows;
        data->deepen_not = deepen_not;
 9:  d04f78999b ! 10:  2fa59d6c89 upload-pack: move allow_filter to upload_pack_data
    @@ Commit message
         more thoroughly, let's move the 'allow_filter' static variable
         into this struct.
     
    -    It is only used by protocol v0 code since protocol v2 assumes
    -    certain baseline capabilities, but rolling it into
    -    upload_pack_data and just letting v2 code ignore it as it does
    -    now is more coherent and cleaner.
    +    It is used by both protocol v0 and protocol v2 code.
     
         Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
     
    @@ upload-pack.c: static int shallow_nr;
      
      static int allow_sideband_all;
     @@ upload-pack.c: struct upload_pack_data {
    -   unsigned done : 1;
    -   unsigned no_done : 1;
    -   unsigned filter_capability_requested : 1;
    -+
    +   unsigned use_ofs_delta : 1;
    +   unsigned no_progress : 1;
    +   unsigned use_include_tag : 1;
     +  unsigned allow_filter : 1;
    - };
      
    - static void upload_pack_data_init(struct upload_pack_data *data)
    +   unsigned done : 1;                                      /* v2 only */
    + };
     @@ upload-pack.c: static void receive_needs(struct upload_pack_data *data,
                        data->no_progress = 1;
                if (parse_feature_request(features, "include-tag"))
10:  9e99d94c33 ! 11:  d501b0f694 upload-pack: move allow_ref_in_want to upload_pack_data
    @@ Commit message
         more thoroughly, let's move the 'allow_ref_in_want' static
         variable into this struct.
     
    -    It is only used by protocol v0 code since protocol v2 assumes
    -    certain baseline capabilities, but rolling it into
    -    upload_pack_data and just letting v2 code ignore it as it does
    -    now is more coherent and cleaner.
    +    It is used only by protocol v2 code.
     
         Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
     
    @@ upload-pack.c: static int shallow_nr;
     -
      static int allow_sideband_all;
      
    - struct upload_pack_data {
    + /*
     @@ upload-pack.c: struct upload_pack_data {
    -   unsigned filter_capability_requested : 1;
    - 
        unsigned allow_filter : 1;
    -+  unsigned allow_ref_in_want : 1;
    + 
    +   unsigned done : 1;                                      /* v2 only */
    ++  unsigned allow_ref_in_want : 1;                         /* v2 only */
      };
      
      static void upload_pack_data_init(struct upload_pack_data *data)
11:  64928f291d ! 12:  90513f0543 upload-pack: move allow_sideband_all to upload_pack_data
    @@ upload-pack.c: static int shallow_nr;
      
     -static int allow_sideband_all;
     -
    - struct upload_pack_data {
    -   struct string_list symref;
    -   struct string_list wanted_refs;
    + /*
    +  * Please annotate, and if possible group together, fields used only
    +  * for protocol v0 or only for protocol v2.
     @@ upload-pack.c: struct upload_pack_data {
      
    -   unsigned allow_filter : 1;
    -   unsigned allow_ref_in_want : 1;
    -+  unsigned allow_sideband_all : 1;
    +   unsigned done : 1;                                      /* v2 only */
    +   unsigned allow_ref_in_want : 1;                         /* v2 only */
    ++  unsigned allow_sideband_all : 1;                        /* v2 only */
      };
      
      static void upload_pack_data_init(struct upload_pack_data *data)
12:  07c5ed9528 ! 13:  f2851482f5 upload-pack: move pack_objects_hook to upload_pack_data
    @@ upload-pack.c: static timestamp_t oldest_have;
      static struct object_array extra_edge_obj;
     -static const char *pack_objects_hook;
      
    - struct upload_pack_data {
    -   struct string_list symref;
    + /*
    +  * Please annotate, and if possible group together, fields used only
     @@ upload-pack.c: struct upload_pack_data {
      
        struct packet_writer writer;
      
     +  const char *pack_objects_hook;
     +
    -   unsigned stateless_rpc : 1;
    -   unsigned daemon_mode : 1;
    - 
    +   unsigned stateless_rpc : 1;                             /* v0 only */
    +   unsigned no_done : 1;                                   /* v0 only */
    +   unsigned daemon_mode : 1;                               /* v0 only */
     @@ upload-pack.c: static void upload_pack_data_clear(struct upload_pack_data *data)
        object_array_clear(&data->shallows);
        string_list_clear(&data->deepen_not, 0);
    @@ upload-pack.c: static void upload_pack_data_clear(struct upload_pack_data *data)
     +  free((char *)data->pack_objects_hook);
      }
      
    - static void reset_timeout(int timeout)
    + static void reset_timeout(unsigned int timeout)
     @@ upload-pack.c: static void create_pack_file(struct upload_pack_data *pack_data)
        int i;
        FILE *pipe_fd;


Christian Couder (12):
  upload-pack: annotate upload_pack_data fields
  upload-pack: move static vars to upload_pack_data
  upload-pack: move use_sideband to upload_pack_data
  upload-pack: move filter_capability_requested to upload_pack_data
  upload-pack: move multi_ack to upload_pack_data
  upload-pack: change multi_ack to an enum
  upload-pack: pass upload_pack_data to upload_pack_config()
  upload-pack: move keepalive to upload_pack_data
  upload-pack: move allow_filter to upload_pack_data
  upload-pack: move allow_ref_in_want to upload_pack_data
  upload-pack: move allow_sideband_all to upload_pack_data
  upload-pack: move pack_objects_hook to upload_pack_data

Jeff King (1):
  upload-pack: actually use some upload_pack_data bitfields

 upload-pack.c | 199 ++++++++++++++++++++++++++++----------------------
 1 file changed, 110 insertions(+), 89 deletions(-)

-- 
2.27.0.rc0.26.g636377a2c4


  parent reply	other threads:[~2020-06-02  4:17 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 10:04 [PATCH 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 1 Christian Couder
2020-05-15 10:04 ` [PATCH 01/13] upload-pack: remove unused 'wants' from upload_pack_data Christian Couder
2020-05-15 18:03   ` Jeff King
2020-05-15 10:04 ` [PATCH 02/13] upload-pack: move {want,have}_obj to upload_pack_data Christian Couder
2020-05-15 18:05   ` Jeff King
2020-05-15 10:04 ` [PATCH 03/13] upload-pack: move 'struct upload_pack_data' around Christian Couder
2020-05-15 18:05   ` Jeff King
2020-05-15 10:04 ` [PATCH 04/13] upload-pack: use 'struct upload_pack_data' in upload_pack() Christian Couder
2020-05-15 10:30   ` Derrick Stolee
2020-05-15 18:13     ` Jeff King
2020-05-15 10:04 ` [PATCH 05/13] upload-pack: pass upload_pack_data to get_common_commits() Christian Couder
2020-05-15 18:17   ` Jeff King
2020-05-15 18:36     ` Jeff King
2020-05-15 10:04 ` [PATCH 06/13] upload-pack: pass upload_pack_data to receive_needs() Christian Couder
2020-05-15 18:20   ` Jeff King
2020-05-15 10:04 ` [PATCH 07/13] upload-pack: use upload_pack_data writer in receive_needs() Christian Couder
2020-05-15 18:23   ` Jeff King
2020-05-15 10:04 ` [PATCH 08/13] upload-pack: move symref to upload_pack_data Christian Couder
2020-05-15 18:28   ` Jeff King
2020-05-15 10:04 ` [PATCH 09/13] upload-pack: pass upload_pack_data to send_ref() Christian Couder
2020-05-15 18:33   ` Jeff King
2020-05-15 10:04 ` [PATCH 10/13] upload-pack: pass upload_pack_data to check_non_tip() Christian Couder
2020-05-15 10:04 ` [PATCH 11/13] upload-pack: remove static variable 'stateless_rpc' Christian Couder
2020-05-15 18:38   ` Jeff King
2020-05-15 10:04 ` [PATCH 12/13] upload-pack: pass upload_pack_data to create_pack_file() Christian Couder
2020-05-15 10:04 ` [PATCH 13/13] upload-pack: use upload_pack_data fields in receive_needs() Christian Couder
2020-05-15 18:42   ` Jeff King
2020-05-15 10:43 ` [PATCH 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 1 Derrick Stolee
2020-05-19  9:49   ` Christian Couder
2020-05-15 18:47 ` Jeff King
2020-05-15 18:55   ` Jeff King
2020-05-19  9:44     ` Christian Couder
2020-05-27 16:47 ` [PATCH 00/12] upload-pack: use 'struct upload_pack_data' thoroughly, part 2 Christian Couder
2020-05-27 16:47   ` [PATCH 01/12] upload-pack: actually use some upload_pack_data bitfields Christian Couder
2020-05-27 16:47   ` [PATCH 02/12] upload-pack: move static vars to upload_pack_data Christian Couder
2020-05-27 18:06     ` Jeff King
2020-06-02  4:19       ` Christian Couder
2020-05-27 16:47   ` [PATCH 03/12] upload-pack: move use_sideband " Christian Couder
2020-05-27 18:07     ` Jeff King
2020-05-27 16:47   ` [PATCH 04/12] upload-pack: move filter_capability_requested " Christian Couder
2020-05-27 18:08     ` Jeff King
2020-05-27 16:47   ` [PATCH 05/12] upload-pack: move multi_ack " Christian Couder
2020-05-27 16:47   ` [PATCH 06/12] upload-pack: change multi_ack to an enum Christian Couder
2020-05-27 18:10     ` Jeff King
2020-05-27 16:47   ` [PATCH 07/12] upload-pack: pass upload_pack_data to upload_pack_config() Christian Couder
2020-05-27 18:36     ` Jeff King
2020-05-27 16:47   ` [PATCH 08/12] upload-pack: move keepalive to upload_pack_data Christian Couder
2020-05-27 18:38     ` Jeff King
2020-05-27 16:47   ` [PATCH 09/12] upload-pack: move allow_filter " Christian Couder
2020-05-27 18:39     ` Jeff King
2020-05-27 16:47   ` [PATCH 10/12] upload-pack: move allow_ref_in_want " Christian Couder
2020-05-27 18:41     ` Jeff King
2020-05-27 16:47   ` [PATCH 11/12] upload-pack: move allow_sideband_all " Christian Couder
2020-05-27 16:47   ` [PATCH 12/12] upload-pack: move pack_objects_hook " Christian Couder
2020-05-27 18:55     ` Jeff King
2020-05-27 18:57   ` [PATCH 00/12] upload-pack: use 'struct upload_pack_data' thoroughly, part 2 Jeff King
2020-05-27 20:41     ` Junio C Hamano
2020-06-02  4:16   ` Christian Couder [this message]
2020-06-02  4:16     ` [PATCH v2 01/13] upload-pack: actually use some upload_pack_data bitfields Christian Couder
2020-06-02  4:16     ` [PATCH v2 02/13] upload-pack: annotate upload_pack_data fields Christian Couder
2020-06-02  4:16     ` [PATCH v2 03/13] upload-pack: move static vars to upload_pack_data Christian Couder
2020-06-02  6:59       ` Jeff King
2020-06-02  4:16     ` [PATCH v2 04/13] upload-pack: move use_sideband " Christian Couder
2020-06-02  4:16     ` [PATCH v2 05/13] upload-pack: move filter_capability_requested " Christian Couder
2020-06-02  4:16     ` [PATCH v2 06/13] upload-pack: move multi_ack " Christian Couder
2020-06-02  4:16     ` [PATCH v2 07/13] upload-pack: change multi_ack to an enum Christian Couder
2020-06-02  4:16     ` [PATCH v2 08/13] upload-pack: pass upload_pack_data to upload_pack_config() Christian Couder
2020-06-02  4:16     ` [PATCH v2 09/13] upload-pack: move keepalive to upload_pack_data Christian Couder
2020-06-02  4:16     ` [PATCH v2 10/13] upload-pack: move allow_filter " Christian Couder
2020-06-02  4:16     ` [PATCH v2 11/13] upload-pack: move allow_ref_in_want " Christian Couder
2020-06-02  4:16     ` [PATCH v2 12/13] upload-pack: move allow_sideband_all " Christian Couder
2020-06-02  4:16     ` [PATCH v2 13/13] upload-pack: move pack_objects_hook " Christian Couder
2020-06-02  7:08     ` [PATCH v2 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 2 Jeff King
2020-06-02 17:24       ` Junio C Hamano
2020-06-02 19:05     ` [PATCH] fixup! upload-pack: change multi_ack to an enum Jonathan Tan
2020-06-02 19:28       ` Christian Couder
2020-06-04 17:54     ` [PATCH v3 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 2 Christian Couder
2020-06-04 17:54       ` [PATCH v3 01/13] upload-pack: actually use some upload_pack_data bitfields Christian Couder
2020-06-04 17:54       ` [PATCH v3 02/13] upload-pack: annotate upload_pack_data fields Christian Couder
2020-06-04 17:54       ` [PATCH v3 03/13] upload-pack: move static vars to upload_pack_data Christian Couder
2020-06-04 17:54       ` [PATCH v3 04/13] upload-pack: move use_sideband " Christian Couder
2020-06-04 17:54       ` [PATCH v3 05/13] upload-pack: move filter_capability_requested " Christian Couder
2020-06-04 17:54       ` [PATCH v3 06/13] upload-pack: move multi_ack " Christian Couder
2020-06-04 17:54       ` [PATCH v3 07/13] upload-pack: change multi_ack to an enum Christian Couder
2020-06-04 17:54       ` [PATCH v3 08/13] upload-pack: pass upload_pack_data to upload_pack_config() Christian Couder
2020-06-04 17:54       ` [PATCH v3 09/13] upload-pack: move keepalive to upload_pack_data Christian Couder
2020-06-04 17:54       ` [PATCH v3 10/13] upload-pack: move allow_filter " Christian Couder
2020-06-04 17:54       ` [PATCH v3 11/13] upload-pack: move allow_ref_in_want " Christian Couder
2020-06-04 17:54       ` [PATCH v3 12/13] upload-pack: move allow_sideband_all " Christian Couder
2020-06-04 17:54       ` [PATCH v3 13/13] upload-pack: move pack_objects_hook " Christian Couder
2020-06-04 18:07       ` [PATCH v3 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 2 Junio C Hamano
2020-06-05 10:38         ` Christian Couder
2020-06-11 12:05 ` [PATCH 00/14] upload-pack: use 'struct upload_pack_data' thoroughly, part 3 Christian Couder
2020-06-11 12:05   ` [PATCH 01/14] upload-pack: pass upload_pack_data to send_shallow_list() Christian Couder
2020-06-11 12:05   ` [PATCH 02/14] upload-pack: pass upload_pack_data to deepen() Christian Couder
2020-06-11 12:05   ` [PATCH 03/14] upload-pack: pass upload_pack_data to deepen_by_rev_list() Christian Couder
2020-06-11 12:05   ` [PATCH 04/14] upload-pack: pass upload_pack_data to send_unshallow() Christian Couder
2020-06-11 12:05   ` [PATCH 05/14] upload-pack: move shallow_nr to upload_pack_data Christian Couder
2020-06-11 12:05   ` [PATCH 06/14] upload-pack: move extra_edge_obj " Christian Couder
2020-06-11 12:05   ` [PATCH 07/14] upload-pack: move allow_unadvertised_object_request " Christian Couder
2020-06-11 12:05   ` [PATCH 08/14] upload-pack: change allow_unadvertised_object_request to an enum Christian Couder
2020-06-11 12:05   ` [PATCH 09/14] upload-pack: pass upload_pack_data to process_haves() Christian Couder
2020-06-11 12:05   ` [PATCH 10/14] upload-pack: pass upload_pack_data to send_acks() Christian Couder
2020-06-11 12:05   ` [PATCH 11/14] upload-pack: pass upload_pack_data to ok_to_give_up() Christian Couder
2020-06-11 12:05   ` [PATCH 12/14] upload-pack: pass upload_pack_data to got_oid() Christian Couder
2020-06-11 12:05   ` [PATCH 13/14] upload-pack: move oldest_have to upload_pack_data Christian Couder
2020-06-11 12:05   ` [PATCH 14/14] upload-pack: refactor common code into do_got_oid() Christian Couder
2020-06-11 20:04   ` [PATCH 00/14] upload-pack: use 'struct upload_pack_data' thoroughly, part 3 Jonathan Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602041657.7132-1-chriscool@tuxfamily.org \
    --to=christian.couder@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).