From: Jonathan Tan <jonathantanmy@google.com>
To: luke@diamand.org
Cc: git@vger.kernel.org, andrew@adoakley.name,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: git clone --filter=blob:limit=X interaction with submodules?
Date: Wed, 17 Jun 2020 16:20:18 -0700 [thread overview]
Message-ID: <20200617232018.148877-1-jonathantanmy@google.com> (raw)
In-Reply-To: <CAE5ih79vZDzKQ1TSNTrL_64XjZH-DJTPqdPH5NMwOrsbaH=n+g@mail.gmail.com>
> I noticed that if I do git clone with submodules, using
> "--filter=blob:limit=whatever" that the filter is applied in the super
> project, but appears to be ignored in the sub modules.
>
> Is that expected behaviour? Or am I just doing it wrong?
>
> I'm using git 2.27.0.90.geebb51ba8c.
>
> Thanks
> Luke
Yes, that's expected. The main technical reason is that a lot of the
subsequent submodule operations may read objects from the submodules,
and those could trigger on-demand fetches (if the submodules were
themselves partial clones) - but right now the fetch code is designed to
run only on one repository.
For those who would like to improve this state of affairs, one step in
the right direction would be to update the fetch and transport code to
support an arbitrary "struct repository" passed in, and not just operate
on the_repository.
next prev parent reply other threads:[~2020-06-17 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 19:14 git clone --filter=blob:limit=X interaction with submodules? Luke Diamand
2020-06-17 23:20 ` Jonathan Tan [this message]
2020-06-19 14:00 ` Luke Diamand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617232018.148877-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=andrew@adoakley.name \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).