From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Matheus Tavares <matheus.bernardino@usp.br>
Cc: git@vger.kernel.org, j6t@kdbg.org, jonathantanmy@google.com,
peff@peff.net, Johannes.Schindelin@gmx.de,
Fredrik Kuivinen <frekui@gmail.com>
Subject: Re: [PATCH 2/2] hex: make hash_to_hex_algop() and friends thread-safe
Date: Thu, 25 Jun 2020 23:07:53 +0000 [thread overview]
Message-ID: <20200625230753.GB9782@camp.crustytoothpaste.net> (raw)
In-Reply-To: <0104cd9c763aee220a2df357834c79b10695ee35.1593115455.git.matheus.bernardino@usp.br>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
On 2020-06-25 at 20:32:57, Matheus Tavares wrote:
> +#ifdef HAVE_THREADS
> + void *value;
> +
> + if (pthread_once(&hexbuf_array_once, init_hexbuf_array_key))
> + die(_("failed to initialize threads' key for hash to hex conversion"));
> +
> + value = pthread_key_getspecific(&hexbuf_array_key);
I think the portable name for this is "pthread_getspecific". That
appears to be what POSIX specifies and what our Windows pthread compat
code uses.
> + if (value) {
> + ha = (struct hexbuf_array *) value;
> + } else {
> + ha = xmalloc(sizeof(*ha));
> + if (pthread_key_setspecific(&hexbuf_array_key, (void *)ha))
Same thing here.
> + die(_("failed to set thread buffer for hash to hex conversion"));
> + }
> +#else
> + ha = &default_hexbuf_array;
> +#endif
> +
> + ha->idx = (ha->idx + 1) % ARRAY_SIZE(ha->bufs);
> + return hash_to_hex_algop_r(ha->bufs[ha->idx], hash, algop);
> }
>
> char *hash_to_hex(const unsigned char *hash)
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-06-25 23:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 22:29 [RFC] Thread safety in some low-level functions Matheus Tavares Bernardino
2020-06-24 22:52 ` Matheus Tavares Bernardino
2020-06-25 1:38 ` brian m. carlson
2020-06-25 20:32 ` [PATCH 0/2] Make oid_to_hex() thread-safe Matheus Tavares
2020-06-25 20:32 ` [PATCH 1/2] compat/win32/pthread: add pthread_once() Matheus Tavares
2020-06-26 5:45 ` Christian Couder
2020-06-26 14:13 ` Matheus Tavares Bernardino
2020-06-25 20:32 ` [PATCH 2/2] hex: make hash_to_hex_algop() and friends thread-safe Matheus Tavares
2020-06-25 23:07 ` brian m. carlson [this message]
2020-06-25 23:54 ` Matheus Tavares Bernardino
2020-06-26 0:00 ` Matheus Tavares Bernardino
2020-06-26 6:02 ` Christian Couder
2020-06-26 8:22 ` [PATCH 0/2] Make oid_to_hex() thread-safe Christian Couder
2020-06-26 16:22 ` Matheus Tavares Bernardino
2020-06-26 21:54 ` [PATCH v2 " Matheus Tavares
2020-06-26 21:54 ` [PATCH v2 1/2] compat/win32/pthread: add pthread_once() Matheus Tavares
2020-06-26 21:54 ` [PATCH v2 2/2] hex: make hash_to_hex_algop() and friends thread-safe Matheus Tavares
2020-06-29 15:11 ` Johannes Schindelin
2020-06-30 20:37 ` Matheus Tavares Bernardino
2020-07-01 11:32 ` Johannes Schindelin
2020-07-16 11:29 ` Johannes Schindelin
2020-07-18 3:09 ` Matheus Tavares Bernardino
2020-08-10 14:15 ` Johannes Schindelin
2020-07-18 3:52 ` Matheus Tavares
2020-07-26 17:41 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625230753.GB9782@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jonathantanmy@google.com \
--cc=matheus.bernardino@usp.br \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).