From: Shourya Shukla <shouryashukla.oo@gmail.com> To: git@vger.kernel.org Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de, peff@peff.net, Shourya Shukla <shouryashukla.oo@gmail.com> Subject: [GSoC][PATCH 0/4] t7401: modernize, cleanup and warn Date: Sun, 26 Jul 2020 19:55:49 +0530 [thread overview] Message-ID: <20200726142553.42545-1-shouryashukla.oo@gmail.com> (raw) Greetings, The current phase of my GSoC project involves porting 'git submodule summary' from shell to C. While doing so, I, along with my mentors Christian and Kaartic noticed some discrepancies in the test script when trying to add a couple of tests to it. Though the test works perfectly for my C port of 'summary', there were some unexpected behaviours when trying to some tests to it. This patch series addresses these issues in the test script by modernizing it, cleaning it up and warning about some other issues. Chiefly about patch 4/4 (t7401: add a WARNING and a NEEDSWORK), when trying to write a test for verifying the summary output of deinitialized submodule, doing a 'git submodule deinit <path>' did not bear any fruit since the submodule never really got deinitialized. The deinit documentation states that: Unregister the given submodules, i.e. remove the whole submodule.$name section from .git/config together with their work tree. Something which was not actually happening in the test. It appeared that the reason for the deinit issue is that the test script uses 'git add' to add submodules instead of the command 'git submodule add'. This behaviour also prompted the need to design a new test script to have a testing of some niche cases such as those stated before, but this is something that will be covered in the patch series responsible for porting the 'summary' subcommand to C. Comments and reviews are appreciated. Thanks, Shourya Shukla Shourya Shukla (4): t7401: modernize style t7401: change test_i18ncmp syntax for clarity t7401: ensure uniformity in the '--for-status' test t7401: add a WARNING and a NEEDSWORK t/t7401-submodule-summary.sh | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.27.0
next reply other threads:[~2020-07-26 14:26 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-26 14:25 Shourya Shukla [this message] 2020-07-26 14:25 ` [PATCH 1/4] t7401: modernize style Shourya Shukla 2020-07-26 14:25 ` [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla 2020-07-26 14:25 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla 2020-07-26 14:25 ` [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Shourya Shukla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200726142553.42545-1-shouryashukla.oo@gmail.com \ --to=shouryashukla.oo@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=peff@peff.net \ --subject='Re: [GSoC][PATCH 0/4] t7401: modernize, cleanup and warn' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).