Git Mailing List Archive on lore.kernel.org
 help / color / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, peff@peff.net, dstolee@microsoft.com
Subject: Re: [PATCH 0/3] commit-graph: introduce 'core.useBloomFilters'
Date: Mon, 3 Aug 2020 15:02:11 -0400
Message-ID: <20200803190211.GA67539@syl.lan> (raw)
In-Reply-To: <cover.1593536481.git.me@ttaylorr.com>

On Tue, Jun 30, 2020 at 01:17:36PM -0400, Taylor Blau wrote:
> Hi,
>
> Here are some patches that we have been using at GitHub to control
> whether or not Bloom filters stored in commit-graphs are read during
> normal operation.

I took the suggestions raised here and incorporated them into a
much-larger series that contains updated versions of these patches here:

  https://lore.kernel.org/git/20200803185947.GA67482@syl.lan/

This thread should be discarded, and future discussion redirected above.

Thanks.

>
> -Taylor
>
> Taylor Blau (3):
>   commit-graph: pass a 'struct repository *' in more places
>   t4216: fix broken '&&'-chain
>   commit-graph: respect 'core.useBloomFilters'
>
>  Documentation/config/core.txt |  5 +++++
>  builtin/commit-graph.c        |  2 +-
>  commit-graph.c                | 17 ++++++++++-------
>  commit-graph.h                |  4 +++-
>  fuzz-commit-graph.c           |  5 +++--
>  repo-settings.c               |  3 +++
>  repository.h                  |  1 +
>  t/helper/test-read-graph.c    |  3 ++-
>  t/t4216-log-bloom.sh          |  6 ++++--
>  9 files changed, 32 insertions(+), 14 deletions(-)
>
> --
> 2.27.0.224.g4cfa086e50

Thanks,
Taylor

      parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 17:17 Taylor Blau
2020-06-30 17:17 ` [PATCH 1/3] commit-graph: pass a 'struct repository *' in more places Taylor Blau
2020-06-30 20:52   ` Derrick Stolee
2020-06-30 17:17 ` [PATCH 2/3] t4216: fix broken '&&'-chain Taylor Blau
2020-06-30 17:50   ` Eric Sunshine
2020-06-30 18:39     ` Taylor Blau
2020-06-30 19:03       ` Jeff King
2020-06-30 19:12         ` Taylor Blau
2020-06-30 19:19           ` Jeff King
2020-06-30 19:48         ` Eric Sunshine
2020-06-30 18:55     ` Jeff King
2020-06-30 17:17 ` [PATCH 3/3] commit-graph: respect 'core.useBloomFilters' Taylor Blau
2020-06-30 19:18   ` Jeff King
2020-06-30 19:27     ` Taylor Blau
2020-06-30 19:33       ` Jeff King
2020-08-03 19:02 ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803190211.GA67539@syl.lan \
    --to=me@ttaylorr.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Mailing List Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/git/0 git/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 git git/ https://lore.kernel.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.git


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git