git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: sunshine@sunshineco.com
Cc: git@vger.kernel.org, newren@gmail.com
Subject: Re: [PATCH] test_cmp: diagnose incorrect arguments
Date: Sun, 9 Aug 2020 14:02:27 +0530	[thread overview]
Message-ID: <20200809083227.GA11219@konoha> (raw)
In-Reply-To: <20200809060810.31370-1-sunshine@sunshineco.com>

Hello Eric,

>  test_cmp() {
> -	eval "$GIT_TEST_CMP" '"$@"'
> +	test $# -eq 2 || BUG "test_cmp requires two arguments"
> +	if ! eval "$GIT_TEST_CMP" '"$@"'
> +	then
> +		test -e "$1" || BUG "test_cmp 'expect' file missing"
> +		test -e "$2" || BUG "test_cmp 'actual' file missing"
> +		return 1
> +	fi
>  }

I reckon we could be just a little bit more precise here by bugging out
with the exact filename which is missing instead of 'expect' or 'actual'
so that the user has more idea as to what happened. What do you think?

BTW, I looked up the 'test_i18ncmp' function as well and if we have
this small loophole you mentioned above, I think maybe we could make a
similar fix for it too. What I mean is that in case of absence of the
required locale, it should error out kind of like what we did above

    BUG "locale missing"


so that the user it is clear to the user what was the failure point.
Though I will be honest that I have not really encountered a locale related
error or seen what the error looks like, so maybe we can ignore this
suggestion.

Regards,
Shourya Shukla


  reply	other threads:[~2020-08-09  8:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-09  6:08 [PATCH] test_cmp: diagnose incorrect arguments Eric Sunshine
2020-08-09  8:32 ` Shourya Shukla [this message]
2020-08-09  8:49   ` Eric Sunshine
2020-08-09 17:42 ` [PATCH v2] " Eric Sunshine
2020-08-09 19:12   ` Junio C Hamano
2020-08-09 19:34     ` Eric Sunshine
2020-08-10 15:22       ` Junio C Hamano
2020-08-11 18:32   ` Taylor Blau
2020-08-11 19:25     ` Eric Sunshine
2020-08-11 21:03       ` Taylor Blau
2020-08-12 15:37       ` Jeff King
2020-08-12 16:15         ` Eric Sunshine
2020-08-12 16:39           ` Eric Sunshine
2020-08-12 17:10             ` Jeff King
2020-10-16  0:17   ` Jeff King
2020-10-16  2:18     ` Eric Sunshine
2020-10-16 18:36       ` Junio C Hamano
2020-10-16 20:56         ` Junio C Hamano
2020-10-16 23:14           ` Junio C Hamano
2020-10-17  6:06             ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200809083227.GA11219@konoha \
    --to=shouryashukla.oo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).