From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] init: disallow --separate-git-dir with bare repository
Date: Tue, 11 Aug 2020 05:02:45 -0400 [thread overview]
Message-ID: <20200811090245.GA2050353@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPig+cSMzEuMYNnHhMGwqGFgjWfX0+j1KoOSK8V7Wav97p+UVw@mail.gmail.com>
On Tue, Aug 11, 2020 at 01:44:00AM -0400, Eric Sunshine wrote:
> > I agree that it seems like nonsense. I'm a little curious what it
> > happens to do today, just because I'd wonder if it could possibly be of
> > any use to somebody.
>
> The current behavior does some goofy stuff which I can't imagine being
> useful to anyone. For instance:
> [...]
OK, that's sufficiently brain-dead that I agree nobody will be sad to
see it go. Thanks for indulging me. :)
> > I think we'd clean up that detritus with our atexit handler, but I like
> > the extra check here. It lets us give a slightly more specific message
> > when we can catch it early ("these two options are incompatible").
>
> With only the latter (after-the-fact) check:
>
> % git init --bare --separate-git-dir bar.git foo.git
> fatal: --separate-git-dir incompatible with bare repository
> % ls -1
> foo.git
> % ls -A foo.git/
> %
>
> It leaves the directory "foo.git" around, though the directory is
> empty. With the earlier check in place, it avoids leaving that empty
> directory.
Ah, right. git-clone has some magic auto-cleanup for signals/atexit, but
git-init does not. It might be worth adding that, but it's definitely
outside the scope of your patch.
-Peff
prev parent reply other threads:[~2020-08-11 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 22:53 [PATCH] init: disallow --separate-git-dir with bare repository Eric Sunshine
2020-08-10 9:56 ` Jeff King
2020-08-11 5:44 ` Eric Sunshine
2020-08-11 9:02 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811090245.GA2050353@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).