From: Alex Riesen <alexander.riesen@cetitec.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
Eric Wong <normalperson@yhbt.net>
Subject: [PATCH] config: option transfer.ipversion to set transport protocol version for network fetches
Date: Tue, 15 Sep 2020 15:54:28 +0200 [thread overview]
Message-ID: <20200915135428.GA28038@pflmari> (raw)
In-Reply-To: <20200915130506.GA2839276@coredump.intra.peff.net>
Affecting the transfers caused by git-fetch, the
option allows to control network operations similar
to --ipv4 and --ipv6 options.
Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Alex Riesen <alexander.riesen@cetitec.com>
---
Jeff King, Tue, Sep 15, 2020 15:05:06 +0200:
> On Tue, Sep 15, 2020 at 01:50:25PM +0200, Alex Riesen wrote:
> > Sure! Thinking about it, I actually would have preferred to have both: a
> > config option and a command-line option. So that I can set --ipv4 in, say,
> > ~/.config/git/config file, but still have the option to try --ipv6 from time
> > to time to check if the network setup magically fixed itself.
> >
> > What would the preferred name for that config option be? fetch.ipv?
>
> It looks like we've got similar options for clone/pull (which are really
> fetch under the hood of course) and push. We have the "transfer.*"
> namespace which applies to both already. So maybe "transfer.ipversion"
> or something?
Something like this?
Documentation/config/transfer.txt | 7 +++++++
builtin/fetch.c | 11 +++++++++++
2 files changed, 18 insertions(+)
diff --git a/Documentation/config/transfer.txt b/Documentation/config/transfer.txt
index f5b6245270..cc0e97fbb1 100644
--- a/Documentation/config/transfer.txt
+++ b/Documentation/config/transfer.txt
@@ -69,3 +69,10 @@ transfer.unpackLimit::
When `fetch.unpackLimit` or `receive.unpackLimit` are
not set, the value of this variable is used instead.
The default value is 100.
+
+transfer.ipversion::
+ Limit the network operations to the specified version of the transport
+ protocol. Can be specified as `4` to allow IPv4 only, `6` for IPv6, or
+ `all` to allow all protocols.
+ See also linkgit:git-fetch[1] options `--ipv4` and `--ipv6`.
+ The default value is `all` to allow all protocols.
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 447d28ac29..da01c8f7b3 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -118,6 +118,17 @@ static int git_fetch_config(const char *k, const char *v, void *cb)
return 0;
}
+ if (!strcmp(k, "transfer.ipversion")) {
+ if (!strcmp(v, "all"))
+ ;
+ else if (!strcmp(v, "4"))
+ family = TRANSPORT_FAMILY_IPV4;
+ else if (!strcmp(v, "6"))
+ family = TRANSPORT_FAMILY_IPV6;
+ else
+ die(_("transfer.ipversion can be only 4, 6, or any"));
+ return 0;
+ }
return git_default_config(k, v, cb);
}
--
2.28.0.21.g178b32a6fd.dirty
next prev parent reply other threads:[~2020-09-16 0:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:19 sub-fetches discard --ipv4|6 option Alex Riesen
2020-09-14 19:49 ` Jeff King
2020-09-15 11:50 ` Alex Riesen
2020-09-15 11:54 ` [PATCH] Pass --ipv4 and --ipv6 options to sub-fetches when fetching multiple remotes and submodules Alex Riesen
2020-09-15 13:06 ` Jeff King
2020-09-16 4:17 ` Junio C Hamano
2020-09-16 7:27 ` Alex Riesen
2020-09-15 21:19 ` Junio C Hamano
2020-09-16 7:25 ` Alex Riesen
2020-09-15 13:05 ` sub-fetches discard --ipv4|6 option Jeff King
2020-09-15 13:54 ` Alex Riesen [this message]
2020-09-16 20:02 ` [PATCH] config: option transfer.ipversion to set transport protocol version for network fetches Jeff King
2020-09-17 8:07 ` Alex Riesen
2020-09-17 13:20 ` [PATCH] Config option to set the " Alex Riesen
2020-09-17 13:26 ` Alex Riesen
2020-09-17 13:31 ` Jeff King
2020-09-17 13:35 ` Alex Riesen
2020-09-17 14:51 ` Jeff King
2020-09-17 15:17 ` Alex Riesen
2020-12-22 19:55 ` Junio C Hamano
2021-01-07 10:06 ` Alex Riesen
2020-09-17 16:05 ` Alex Riesen
2020-09-16 20:14 ` [PATCH] config: option transfer.ipversion to set " Junio C Hamano
2020-09-16 20:18 ` Jeff King
2020-09-16 22:50 ` Junio C Hamano
2020-09-16 22:52 ` Junio C Hamano
2020-09-17 0:48 ` Jeff King
2020-09-17 0:57 ` Junio C Hamano
2020-09-16 21:35 ` Junio C Hamano
2020-09-17 14:02 ` Alex Riesen
2020-09-17 22:31 ` Junio C Hamano
2020-09-18 7:16 ` Alex Riesen
2020-09-18 16:37 ` Junio C Hamano
2020-09-21 16:39 ` Alex Riesen
2020-09-22 5:03 ` Jeff King
2020-09-17 8:04 ` Alex Riesen
2020-09-17 8:18 ` Alex Riesen
2020-09-15 14:06 ` sub-fetches discard --ipv4|6 option Alex Riesen
2020-09-15 15:27 ` Jeff King
2020-09-15 16:03 ` Alex Riesen
2020-09-16 16:32 ` Jeff King
2020-09-17 14:33 ` Alex Riesen
2020-09-22 5:08 ` Jeff King
2020-09-15 20:09 ` Junio C Hamano
2020-09-15 21:23 ` Jeff King
2020-09-15 21:32 ` Junio C Hamano
2020-09-16 16:34 ` Jeff King
2020-09-16 21:20 ` Junio C Hamano
2020-09-14 20:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915135428.GA28038@pflmari \
--to=alexander.riesen@cetitec.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).