archive mirror
 help / color / mirror / Atom feed
From: Pratyush Yadav <>
To: Serg Tereshchenko <>
Subject: Re: [PATCH v2] style(git-gui): Fix mixed tabs & spaces; Prefer tabs.
Date: Tue, 22 Sep 2020 15:22:41 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 09/09/20 04:01PM, Serg Tereshchenko wrote:
> Hi Pratyush,
> Thanks for suggestion about scissors, i was wondering how to do this
> properly, i'll try it next time.
> > I'm not on board with this entire hunk. In many C projects (like Linux, 
> > Git, etc) the "switch" and the "case" are on the same indent level. I 
> > can see instances of this in almost every switch-case block in 
> > as well. We should stick to the local convention here and 
> > drop this hunk.
> > 
> > I can make these changes locally and merge them so no need to re-roll... 
> > unless you have any counter points that is.
> I have no objections, please drop that hunk.

Merged with the above changes. Thanks.
> --
> Regards,
> Serg Tereshchenko

Pratyush Yadav

      reply	other threads:[~2020-09-22 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22 10:56 style(git-gui): Fix mixed tabs & spaces; Always use tabs Serg Tereshchenko
2020-08-22 19:26 ` Junio C Hamano
2020-08-22 22:24   ` [PATCH v2] style(git-gui): Fix mixed tabs & spaces; Prefer tabs Serg Tereshchenko
2020-09-09  4:51     ` Pratyush Yadav
2020-09-09 13:01       ` Serg Tereshchenko
2020-09-22  9:52         ` Pratyush Yadav [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).