git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miriam Rubio <mirucam@gmail.com>
To: git@vger.kernel.org
Cc: Miriam Rubio <mirucam@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH v9 5/6] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'
Date: Thu, 24 Sep 2020 14:33:39 +0200	[thread overview]
Message-ID: <20200924123340.52632-6-mirucam@gmail.com> (raw)
In-Reply-To: <20200924123340.52632-1-mirucam@gmail.com>

As there can be other revision walks after bisect_next_all(),
let's add a call to a function to clear all the marks at the
end of bisect_next_all().

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
---
 bisect.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/bisect.c b/bisect.c
index d42a3a3767..c6aba2b9f2 100644
--- a/bisect.c
+++ b/bisect.c
@@ -1082,6 +1082,8 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
 		  "Bisecting: %d revisions left to test after this %s\n",
 		  nr), nr, steps_msg);
 	free(steps_msg);
+	/* Clean up objects used, as they will be reused. */
+	clear_commit_marks_all(ALL_REV_FLAGS);
 
 	return bisect_checkout(bisect_rev, no_checkout);
 }
-- 
2.25.0


  parent reply	other threads:[~2020-09-24 12:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 12:33 [PATCH v9 0/6]Finish converting git bisect to C part 2 subset 1 Miriam Rubio
2020-09-24 12:33 ` [PATCH v9 1/6] bisect--helper: BUG() in cmd_*() on invalid subcommand Miriam Rubio
2020-09-24 12:33 ` [PATCH v9 2/6] bisect--helper: use '-res' in 'cmd_bisect__helper' return Miriam Rubio
2020-09-24 12:33 ` [PATCH v9 3/6] bisect--helper: introduce new `write_in_file()` function Miriam Rubio
2020-09-24 12:33 ` [PATCH v9 4/6] bisect--helper: reimplement `bisect_autostart` shell function in C Miriam Rubio
2020-09-24 12:33 ` Miriam Rubio [this message]
2020-09-24 12:33 ` [PATCH v9 6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions " Miriam Rubio
2020-09-29 20:55 ` [PATCH v9 0/6]Finish converting git bisect to C part 2 subset 1 Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924123340.52632-6-mirucam@gmail.com \
    --to=mirucam@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --subject='Re: [PATCH v9 5/6] bisect: call '\''clear_commit_marks_all()'\'' in '\''bisect_next_all()'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).