From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com> To: Johannes Schindelin <Johannes.Schindelin@gmx.de> Cc: "Sibi Siddharthan" <sibisiddharthan.github@gmail.com>, "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>, git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com> Subject: Re: [PATCH 02/10] cmake: do find Git for Windows' shell interpreter Date: Tue, 29 Sep 2020 21:04:13 +0700 [thread overview] Message-ID: <20200929140400.GE20935@danh.dev> (raw) In-Reply-To: <nycvar.QRO.7.76.6.2009281553520.50@tvgsbejvaqbjf.bet> On 2020-09-28 15:56:13+0200, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > Hi Danh, > > On Sun, 27 Sep 2020, Đoàn Trần Công Danh wrote: > > > On 2020-09-26 22:32:25+0200, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > > > > > > I personally don't install my dev tools(except Visual Studio) to > > > > Program Files(because of the _space_), it messes up the Makefiles. > > > > > > Sure, and that's your prerogative. There's unfortunately no good way to > > > support your use case. > > > > > > Luckily, the vast majority of Git for Windows' users do not change the > > > default location, and this patch is for them. (And "them" in this case > > > includes me, personally ;-)) > > > > This doesn't fit into my view of Git for Windows' users > > For some users that have the Administrator right, it's the default > > location if they grant the Administrator right for the installer. > > > > For those poor souls that works for enterprise companies, and thoses > > that not feel comfortable give Administrator right to _another_ > > installer, the installer will install into (hopeful, I type it right): > > > > %USERPROFILE%/AppData/Local/Programs/Git > > Those poor souls that work for enterprise companies often have Git for > Windows installed by default. And of course, that default would be in > `C:\Program Files\Git`. Yes, that's correct, but that Git is usually very old, and I'm not sure about its layout. Obviously, you know better in this regard :-p > > > I think it's better to offer SH_EXE as an OPTION, let user specify it > > as will. And we'll search in PATH if it's not specified, fallback to > > 2 default value if not found. > > That's exactly as it is right now. You can specify `SH_EXE` (but only if > running CMake manually, not via Visual Studio). If you don't, it searches > `PATH`, and with my patch it then falls back to trying to find `sh.exe` in > Git for Windows' default location. > > So I think we're in agreement here? Yes, seems good. -- Danh
next prev parent reply other threads:[~2020-09-29 14:04 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-25 14:28 [PATCH 00/10] CMake and Visual Studio Johannes Schindelin via GitGitGadget 2020-09-25 14:28 ` [PATCH 01/10] cmake: ignore files generated by CMake as run in " Johannes Schindelin via GitGitGadget 2020-09-25 14:28 ` [PATCH 02/10] cmake: do find Git for Windows' shell interpreter Johannes Schindelin via GitGitGadget 2020-09-25 16:25 ` Sibi Siddharthan 2020-09-26 20:32 ` Johannes Schindelin 2020-09-27 2:25 ` Đoàn Trần Công Danh 2020-09-28 13:56 ` Johannes Schindelin 2020-09-29 14:04 ` Đoàn Trần Công Danh [this message] 2020-09-29 18:42 ` Johannes Schindelin 2020-09-25 14:28 ` [PATCH 03/10] cmake: ensure that the `vcpkg` packages are found on Windows Johannes Schindelin via GitGitGadget 2020-09-25 14:28 ` [PATCH 04/10] cmake: fall back to using `vcpkg`'s `msgfmt.exe` " Johannes Schindelin via GitGitGadget 2020-09-25 14:28 ` [PATCH 05/10] cmake: quote the path accurately when editing `test-lib.sh` Johannes Schindelin via GitGitGadget 2020-09-25 14:28 ` [PATCH 06/10] cmake (Windows): let the `.dll` files are found when running the tests Johannes Schindelin via GitGitGadget 2020-09-25 19:48 ` Eric Sunshine 2020-09-26 21:00 ` Johannes Schindelin 2020-09-25 14:28 ` [PATCH 07/10] cmake (Windows): complain when encountering an unknown compiler Johannes Schindelin via GitGitGadget 2020-09-25 17:29 ` Sibi Siddharthan 2020-09-26 20:33 ` Johannes Schindelin 2020-09-25 14:28 ` [PATCH 08/10] cmake (Windows): initialize vcpkg/build dependencies automatically Johannes Schindelin via GitGitGadget 2020-09-30 5:05 ` Sibi Siddharthan 2020-09-30 15:25 ` Johannes Schindelin 2020-09-25 14:28 ` [PATCH 09/10] cmake (Windows): recommend using Visual Studio's built-in CMake support Johannes Schindelin via GitGitGadget 2020-09-25 18:22 ` Junio C Hamano 2020-09-26 20:45 ` Johannes Schindelin 2020-09-25 14:28 ` [PATCH 10/10] hashmap_for_each_entry(): work around MSVC's run-time check failure #3 Johannes Schindelin via GitGitGadget 2020-09-25 18:38 ` Junio C Hamano 2020-09-26 16:54 ` Junio C Hamano 2020-09-26 20:57 ` Johannes Schindelin 2020-09-26 21:32 ` [PATCH v2 00/10] CMake and Visual Studio Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 01/10] cmake: ignore files generated by CMake as run in " Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 02/10] cmake: do find Git for Windows' shell interpreter Johannes Schindelin via GitGitGadget 2020-09-28 11:17 ` Øystein Walle 2020-09-28 19:39 ` Johannes Schindelin 2020-09-26 21:32 ` [PATCH v2 03/10] cmake: ensure that the `vcpkg` packages are found on Windows Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 04/10] cmake: fall back to using `vcpkg`'s `msgfmt.exe` " Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 05/10] cmake: quote the path accurately when editing `test-lib.sh` Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 06/10] cmake (Windows): let the `.dll` files be found when running the tests Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 07/10] cmake (Windows): complain when encountering an unknown compiler Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 08/10] cmake (Windows): initialize vcpkg/build dependencies automatically Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 09/10] cmake (Windows): recommend using Visual Studio's built-in CMake support Johannes Schindelin via GitGitGadget 2020-09-26 21:32 ` [PATCH v2 10/10] hashmap_for_each_entry(): workaround MSVC's runtime check failure #3 Junio C Hamano via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 00/11] CMake and Visual Studio Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 01/11] cmake: ignore files generated by CMake as run in " Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 02/11] cmake: do find Git for Windows' shell interpreter Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 03/11] cmake: ensure that the `vcpkg` packages are found on Windows Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 04/11] cmake: fall back to using `vcpkg`'s `msgfmt.exe` " Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 05/11] cmake: quote the path accurately when editing `test-lib.sh` Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 06/11] cmake (Windows): let the `.dll` files be found when running the tests Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 07/11] cmake (Windows): complain when encountering an unknown compiler Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 08/11] cmake (Windows): initialize vcpkg/build dependencies automatically Johannes Schindelin via GitGitGadget 2020-09-29 6:51 ` Sibi Siddharthan 2020-09-29 12:07 ` Johannes Schindelin 2020-09-28 21:09 ` [PATCH v3 09/11] cmake (Windows): recommend using Visual Studio's built-in CMake support Johannes Schindelin via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 10/11] hashmap_for_each_entry(): workaround MSVC's runtime check failure #3 Junio C Hamano via GitGitGadget 2020-09-28 21:09 ` [PATCH v3 11/11] cmake: fix typo in message when `msgfmt` was not found Johannes Schindelin via GitGitGadget 2020-09-28 22:11 ` Junio C Hamano 2020-09-29 12:07 ` Johannes Schindelin 2020-09-30 15:26 ` [PATCH v4 00/10] CMake and Visual Studio Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 01/10] cmake: ignore files generated by CMake as run in " Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 02/10] cmake: do find Git for Windows' shell interpreter Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 03/10] cmake: ensure that the `vcpkg` packages are found on Windows Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 04/10] cmake: fall back to using `vcpkg`'s `msgfmt.exe` " Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 05/10] cmake: quote the path accurately when editing `test-lib.sh` Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 06/10] cmake (Windows): let the `.dll` files be found when running the tests Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 07/10] cmake (Windows): complain when encountering an unknown compiler Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 08/10] cmake (Windows): initialize vcpkg/build dependencies automatically Johannes Schindelin via GitGitGadget 2020-09-30 19:17 ` Johannes Schindelin 2020-09-30 23:08 ` Junio C Hamano 2020-09-30 15:26 ` [PATCH v4 09/10] cmake (Windows): recommend using Visual Studio's built-in CMake support Johannes Schindelin via GitGitGadget 2020-09-30 15:26 ` [PATCH v4 10/10] hashmap_for_each_entry(): workaround MSVC's runtime check failure #3 Junio C Hamano via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200929140400.GE20935@danh.dev \ --to=congdanhqx@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=sibisiddharthan.github@gmail.com \ --cc=szeder.dev@gmail.com \ --subject='Re: [PATCH 02/10] cmake: do find Git for Windows'\'' shell interpreter' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).