From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/10] dropping more unused parameters
Date: Wed, 30 Sep 2020 08:27:32 -0400 [thread overview]
Message-ID: <20200930122732.GA1901036@coredump.intra.peff.net> (raw)
This is the last of my series of patches to drop (or use) unused
function parameters. I've been holding on to some of these for almost 2
years, because I wanted to make sure they weren't actually bugs
(dropping unused parameters can never _introduce_ a bug, but it's a good
opportunity to investigate whether the parameter _should_ have been
used). I'm still not entirely convinced that patch 10 isn't actually a
bug, but I wasn't able to puzzle it out either way, and it didn't seem
worth holding up the topic any longer.
After this lands, I have a follow-on series that annotates cases where
we can't drop parameters (e.g., functions which have to conform to a
callback interface, but don't care about some of the parameters). And
then after that we can flip on -Wunused-parameters going forward. Which
I think is worth doing, as it has found some bugs (fixed in earlier
series).
[01/10]: convert: drop unused crlf_action from check_global_conv_flags_eol()
[02/10]: drop unused argc parameters
[03/10]: env--helper: write to opt->value in parseopt helper
[04/10]: assert PARSE_OPT_NONEG in parse-options callbacks
[05/10]: push: drop unused repo argument to do_push()
[06/10]: sequencer: drop repository argument from run_git_commit()
[07/10]: sparse-checkout: fill in some options boilerplate
[08/10]: test-advise: check argument count with argc instead of argv
[09/10]: sequencer: handle ignore_footer when parsing trailers
[10/10]: dir.c: drop unused "untracked" from treat_path_fast()
builtin/add.c | 4 +--
builtin/am.c | 2 ++
builtin/commit-graph.c | 2 ++
builtin/commit.c | 12 +++----
builtin/env--helper.c | 13 ++++---
builtin/push.c | 4 +--
builtin/sparse-checkout.c | 37 ++++++++++++++++++++
commit.h | 2 +-
convert.c | 4 +--
dir.c | 3 +-
parse-options-cb.c | 2 ++
revision.c | 6 ++--
sequencer.c | 20 +++++++----
t/helper/test-advise.c | 4 +--
t/helper/test-submodule-nested-repo-config.c | 6 ++--
15 files changed, 88 insertions(+), 33 deletions(-)
-Peff
next reply other threads:[~2020-09-30 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 12:27 Jeff King [this message]
2020-09-30 12:27 ` [PATCH 01/10] convert: drop unused crlf_action from check_global_conv_flags_eol() Jeff King
2020-09-30 12:28 ` [PATCH 02/10] drop unused argc parameters Jeff King
2020-09-30 12:28 ` [PATCH 03/10] env--helper: write to opt->value in parseopt helper Jeff King
2020-09-30 12:29 ` [PATCH 04/10] assert PARSE_OPT_NONEG in parse-options callbacks Jeff King
2020-09-30 12:29 ` [PATCH 05/10] push: drop unused repo argument to do_push() Jeff King
2020-09-30 12:29 ` [PATCH 06/10] sequencer: drop repository argument from run_git_commit() Jeff King
2020-09-30 12:30 ` [PATCH 07/10] sparse-checkout: fill in some options boilerplate Jeff King
2020-09-30 12:30 ` [PATCH 08/10] test-advise: check argument count with argc instead of argv Jeff King
2020-09-30 12:34 ` [PATCH 09/10] sequencer: handle ignore_footer when parsing trailers Jeff King
2020-09-30 12:35 ` [PATCH 10/10] dir.c: drop unused "untracked" from treat_path_fast() Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930122732.GA1901036@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--subject='Re: [PATCH 0/10] dropping more unused parameters' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).