git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild
Date: Wed, 7 Oct 2020 08:49:57 -0400	[thread overview]
Message-ID: <20201007124957.GA123549@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.744.git.1602058669919.gitgitgadget@gmail.com>

On Wed, Oct 07, 2020 at 08:17:49AM +0000, Johannes Schindelin via GitGitGadget wrote:

> It is the custom to follow minor updates of GitHub Actions
> automatically, by using the suffix `@v1`. Actions' maintainers will then
> update that `v1` ref to point to the newest.
> 
> However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure
> GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0`
> suffix.
> 
> In this instance, that is a problem: should `setup-msbuild` release a
> new version that intends to fix a critical bug, we won't know it, and we
> won't use it.
> 
> Such a scenario is not theoretical. It is happening right now:
> https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands
> 
> Let's simplify our setup, allowing us to benefit from automatically
> using the newest v1.x.

Thanks, that explanation makes perfect sense and the patch looks
obviously correct.

-Peff

      reply	other threads:[~2020-10-07 12:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  8:17 [PATCH] GitHub workflow: automatically follow minor updates of setup-msbuild Johannes Schindelin via GitGitGadget
2020-10-07 12:49 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007124957.GA123549@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).