From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Denton Liu <liu.denton@gmail.com>
Subject: Re: [RFC] CodingGuidelines: mark external declarations with "extern"
Date: Sat, 10 Oct 2020 07:37:01 +0700 [thread overview]
Message-ID: <20201010003701.GC27795@danh.dev> (raw)
In-Reply-To: <xmqqpn5rrvfg.fsf@gitster.c.googlers.com>
On 2020-10-09 13:33:39-0700, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
> > The argument for including it is less clear to me. You say below:
> >
> >> [...]By doing so, we would also prevent a
> >> mistake of not writing "extern" when we need to (i.e. decls of data
> >> items, that are not functions) when less experienced developers try
> >> to mimic how the existing surrounding declarations are written.
> >
> > but to my recollection that has not been a big problem. And it's one
> > that's usually easily caught by the compiler. A missing "extern" on a
> > variable will usually get you a multiple-definition warning at
> > link-time (if you manage to also omit the actual definition you won't
> > see that, though "make sparse" will warn that your variable ought to be
> > static).
>
> Not really, that is where the "common" extension comes in, to help
> us with it hurt others without it, unknowingly X-<.
Yes, that's where tentative definition jumpes in.
But, tentative definition is known to cause headache to compiler optimization.
And from GCC 10, gcc change to `-fno-common` by default.
We can enable `-fno-common` now if we can detect our compiler is gcc,
but, I don't think it worth to fiddle with Makefile to add that logic.
>
> $ cat >a.c <<\EOF
> #include <stdio.h>
> #include "c.h"
>
> int common = 47;
>
> int main(int ac, char **av)
> {
> printf("%d\n", common + other);
> return 0;
> }
> EOF
> $ cat >b.c <<\EOF
> #include "c.h"
>
> int other = 22;
> EOF
> $ cat >c.h <<\EOF
> int common;
> int other;
> EOF
> $ gcc -Wall -o c a.c b.c; ./c
> 59
>
> And I have a strong preference, after thinking about it, to have
> "extern" in front in the declarations. It gives another clue for
> patterns I feed to "git grep" to latch onto, and help my eyes to
> scan and tell decls and defns apart in the output.
With this argument, I think adding "extern" is worth it.
It could help people find the code better.
--
Danh
next prev parent reply other threads:[~2020-10-10 0:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:27 [PATCH] clean up extern decl of functions Junio C Hamano
2020-10-09 1:55 ` Denton Liu
2020-10-09 2:47 ` Junio C Hamano
2020-10-09 19:26 ` Junio C Hamano
2020-10-09 19:27 ` [RFC] CodingGuidelines: mark external declarations with "extern" Junio C Hamano
2020-10-09 19:57 ` Jeff King
2020-10-09 20:33 ` Junio C Hamano
2020-10-09 23:00 ` Denton Liu
2020-10-09 23:05 ` Junio C Hamano
2020-10-10 0:37 ` Đoàn Trần Công Danh [this message]
2020-10-15 1:36 ` Jeff King
2020-10-15 17:15 ` Junio C Hamano
2020-10-15 19:28 ` Jeff King
2020-10-15 19:30 ` [PATCH v2 1/2] usage: define a type for a reporting function Jeff King
2020-10-15 19:30 ` [PATCH v2 2/2] config.mak.dev: build with -fno-common Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201010003701.GC27795@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).