From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
"Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
Philippe Blain <levraiphilippeblain@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 0/1] Clarify and expand description of --signoff
Date: Mon, 19 Oct 2020 11:53:38 -0400 [thread overview]
Message-ID: <20201019155338.GK181507@mit.edu> (raw)
In-Reply-To: <xmqqwnzn73og.fsf@gitster.c.googlers.com>
On Sun, Oct 18, 2020 at 12:08:15PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Fri, Oct 16, 2020 at 12:53:56PM -0700, Junio C Hamano wrote:
> >
> >> > Jeff King <peff@peff.net> writes:
> >> >
> >> >> What should we change there? We could perhaps bring up signoffs earlier
> >> >> or more prominently. Or tie it in to the git-commit docs by saying
> >> >> explicitly: these are _our_ project rules for signoffs.
> >>
> >> Let's tie this loose end. How about squashing in something like
> >> this?
> >
> > Thanks for writing this up. I agree it makes the text much better (not
> > only in emphasizing the point we've been discussing, but also in general
> > clarity).
> >
> > You said "squashing", but I'd suggest keeping it as its own patch on top
> > of Bradley's.
>
> OK, let's do so.
>
> I recall I read that Bradley's patch needs a bit of word/grammo
> polishing?
Well, I pointed out a missing article ("a") in the line *above*
Bradley's change in two man pages. It's a minor nit, and it's
unrelated to his proposed change. I have no opinion about whether
it's better to do it separately from his change or as a separate
commit.
- Ted
next prev parent reply other threads:[~2020-10-19 15:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:59 [PATCH 0/1] Clarify and expand description of --signoff Bradley M. Kuhn
2020-10-15 21:59 ` [PATCH 1/1] Documentation: " Bradley M. Kuhn
2020-10-16 0:46 ` Jeff King
2020-10-18 15:13 ` Theodore Y. Ts'o
2020-10-16 1:49 ` [PATCH 0/1] " Philippe Blain
2020-10-16 1:54 ` Junio C Hamano
2020-10-16 1:59 ` Jeff King
2020-10-16 2:30 ` Junio C Hamano
2020-10-16 19:53 ` Junio C Hamano
2020-10-16 20:11 ` Jeff King
2020-10-17 3:00 ` Bradley M. Kuhn
2020-10-18 19:08 ` Junio C Hamano
2020-10-19 15:53 ` Theodore Y. Ts'o [this message]
2020-10-19 18:26 ` Junio C Hamano
2020-10-19 21:25 ` [PATCH v2 0/3] clarify and expand description of --signoff & related fixes Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 1/3] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-19 22:02 ` Taylor Blau
2020-10-19 22:17 ` Junio C Hamano
2020-10-20 2:31 ` Taylor Blau
2020-10-20 1:03 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 1/4] doc: preparatory clean-up of description on the sign-off option Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 2/4] Documentation: clarify and expand description of --signoff Bradley M. Kuhn
2020-10-20 21:44 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 1:03 ` [PATCH v3 3/4] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
2020-10-20 1:03 ` [PATCH v3 4/4] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn
2020-10-20 18:52 ` Junio C Hamano
2020-10-20 21:33 ` Bradley M. Kuhn
2020-10-20 2:34 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Taylor Blau
2020-10-20 21:28 ` Bradley M. Kuhn
2020-10-20 21:48 ` Taylor Blau
2020-10-20 22:06 ` Junio C Hamano
2020-10-20 23:02 ` Bradley M. Kuhn
2020-10-19 21:25 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn
2020-10-18 19:49 [PATCH v2 0/3] Claryfing the meaning of the sign-off Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 1/3] doc: preparatory clean-up of description on the sign-off option Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 2/3] Documentation: clarify and expand description of --signoff Junio C Hamano
2020-10-18 19:49 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Junio C Hamano
2020-10-18 23:31 ` [PATCH v2 0/3] Claryfing the meaning of the sign-off Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019155338.GK181507@mit.edu \
--to=tytso@mit.edu \
--cc=bkuhn@sfconservancy.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=levraiphilippeblain@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).