From: Emily Shaffer <firstname.lastname@example.org> To: "brian m. carlson" <email@example.com> Cc: firstname.lastname@example.org, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, "SZEDER Gábor" <email@example.com> Subject: Re: [PATCH v2 0/2] rev-parse options for absolute or relative paths Date: Wed, 4 Nov 2020 15:01:57 -0800 [thread overview] Message-ID: <20201104230157.GH2774782@google.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hiya, we took a look in the review club, but I'll try to keep it simple. On Fri, Oct 09, 2020 at 07:15:09PM +0000, brian m. carlson wrote: > > There are a bunch of different situations in which one would like to > have an absolute and canonical or a relative path from Git. I think specifically you are interested in this situation: https://github.com/git-lfs/git-lfs/issues/4012 I think this would have been useful to see in the cover letter :) There was a lot of "but why" during the review club meeting. Looking at the git-lfs issue in question, the problem seems to be "how to make sure the path Git gives me will match the path Go gives me" - and like you mentioned in the issue, there are two ways to fix it. Also, there was some brief wondering: if this option is useful in 'git rev-parse', would it be useful in other commands too? I thought maybe it would be more useful as an arg to 'git' itself, but on inspection, not really - because you wouldn't be able to switch the format in the middle of a bunch of args, like you can now. The way it's written here, though, should mean a smooth transition to something like OPT__VERBOSE or OPT__QUIET if we discover lots of folks would find use. Thanks for sending it. I'll try and do a detailed review of the patches themselves. To me, the concept seems sound. - Emily
next prev parent reply other threads:[~2020-11-04 23:02 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-09 19:15 brian m. carlson 2020-10-09 19:15 ` [PATCH v2 1/2] abspath: add a function to resolve paths with missing components brian m. carlson 2020-10-09 21:10 ` Junio C Hamano 2020-10-10 1:10 ` brian m. carlson 2020-11-09 13:57 ` Johannes Schindelin 2020-11-09 13:55 ` Johannes Schindelin 2020-11-16 2:21 ` brian m. carlson 2020-10-09 19:15 ` [PATCH v2 2/2] rev-parse: add option for absolute or relative path formatting brian m. carlson 2020-11-09 14:46 ` Johannes Schindelin 2020-11-16 2:15 ` brian m. carlson 2020-11-04 23:01 ` Emily Shaffer [this message] 2020-11-05 3:20 ` [PATCH v2 0/2] rev-parse options for absolute or relative paths brian m. carlson 2020-11-09 13:33 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201104230157.GH2774782@google.com \ --email@example.com \ --cc=Johannes.Schindelin@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2 0/2] rev-parse options for absolute or relative paths' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).