From: Todd Zullinger <tmz@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
"Arnout Engelen" <arnout@bzzt.net>,
git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH] doc: make HTML manual reproducible
Date: Wed, 2 Dec 2020 11:07:55 -0500 [thread overview]
Message-ID: <20201202160755.GX748@pobox.com> (raw)
In-Reply-To: <X8bhdyu/OlscI1ME@camp.crustytoothpaste.net>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
brian m. carlson wrote:
> On 2020-12-01 at 15:41:15, Todd Zullinger wrote:
>> I think this would raise the minimum supported version of
>> docbook-xsl to 1.77.1. That might be fine, but we'd
>> probably want to make sure it doesn't negatively impact
>> OS/distributions which build the docs as a likely group who
>> care about reproducible builds. And we'd want to update the
>> requirement in INSTALL, of course.
>
> I don't think that's necessarily the case. I just tested using a random
> name with another DocBook project I have and it seems to work fine, so
> there shouldn't be a problem with specifying a name undefined in the
> stylesheet using xsltproc.
Oh, that's very good to know. Thanks for testing the fine
details. I checked that works on a CentOS 6 system where
the docbook-xsl version is 1.75.2, to test whether an older
docbook-xsl is similarly forgiving of unknown --param's.
> If we want this to be effective, then yes, people will need to upgrade.
> But if they're happy with the old behavior on ancient systems, that
> shouldn't be a problem.
Indeed. Is it worth mentioning this at all in INSTALL?
Something like:
- The minimum supported version of docbook-xsl is 1.74.
+ The minimum supported version of docbook-xsl is 1.74. For consistent
+ IDs in the HTML version of the user-manual, 1.79.1 or newer is
+ necessary.
perhaps?
The explicit mention of the user-manual may be overkill,
particularly if we later apply a similar change to other
HTML docs (if any other HTML docs even need it)?
--
Todd
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 543 bytes --]
next prev parent reply other threads:[~2020-12-02 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 9:50 [PATCH] doc: make HTML manual reproducible Arnout Engelen
2020-12-01 15:41 ` Todd Zullinger
2020-12-01 19:18 ` Martin Ågren
2020-12-02 1:54 ` Jeff King
2020-12-01 19:27 ` Junio C Hamano
2020-12-01 19:57 ` Martin Ågren
2020-12-02 0:36 ` brian m. carlson
2020-12-02 16:07 ` Todd Zullinger [this message]
2020-12-02 22:35 ` Junio C Hamano
2020-12-02 23:45 ` brian m. carlson
2020-12-03 1:33 ` Junio C Hamano
2020-12-03 2:00 ` Todd Zullinger
2020-12-03 2:31 ` Re* " Junio C Hamano
2020-12-03 8:07 ` Arnout Engelen
2020-12-02 0:41 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202160755.GX748@pobox.com \
--to=tmz@pobox.com \
--cc=arnout@bzzt.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).