git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Hommey <mh@glandium.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
	Jeff King <peff@peff.net>
Subject: Re: [ANNOUNCE] Git v2.31.0
Date: Tue, 16 Mar 2021 18:10:26 +0900	[thread overview]
Message-ID: <20210316091026.wta7wpxdyr75xo6x@glandium.org> (raw)
In-Reply-To: <875z1rfpmr.fsf@evledraar.gmail.com>

On Tue, Mar 16, 2021 at 09:51:08AM +0100, Ævar Arnfjörð Bjarmason wrote:
> 
> On Tue, Mar 16 2021, Mike Hommey wrote:
> 
> > On Mon, Mar 15, 2021 at 12:30:15PM -0700, Junio C Hamano wrote:
> >>  * Two new ways to feed configuration variable-value pairs via
> >>    environment variables have been introduced, and the way
> >>    GIT_CONFIG_PARAMETERS encodes variable/value pairs has been tweaked
> >>    to make it more robust.
> >
> > For the record, this is backwards incompatible with git-programs in
> > $PATH that were expecting the old format (e.g. git-cinnabar releases
> > using an older version of libgit.a).
> 
> What isn't noted there is that we're still parsing the old format in
> some cases, see f9dbb64fad (config: parse more robust format in
> GIT_CONFIG_PARAMETERS, 2021-01-12).
> 
> But I suspect you mean that you have your own parser that expects the
> old format only, I didn't find which way it was by grepping
> git-cinnabar's sources.

git-cinnabar is using git's libgit.a, so when using a pre-compiled
version built against git < 2.31.0, it fails to parse
GIT_CONFIG_PARAMETERS when used with git 2.31.0.
There's not much I can do apart from releasing a new version.

Mike

  reply	other threads:[~2021-03-16  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 19:30 Junio C Hamano
2021-03-16  5:14 ` Mike Hommey
2021-03-16  8:51   ` Ævar Arnfjörð Bjarmason
2021-03-16  9:10     ` Mike Hommey [this message]
2021-03-16 14:44       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210316091026.wta7wpxdyr75xo6x@glandium.org \
    --to=mh@glandium.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --subject='Re: [ANNOUNCE] Git v2.31.0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).