git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] CodingGuidelines: remove suggestion to write commands in Perl/SH
Date: Sat, 17 Apr 2021 10:53:35 +0200	[thread overview]
Message-ID: <20210417085335.ib6m4jagiekeulec@tb-raspi4> (raw)
In-Reply-To: <patch-1.1-83266f30b67-20210417T084346Z-avarab@gmail.com>

On Sat, Apr 17, 2021 at 10:43:54AM +0200, Ævar Arnfjörð Bjarmason wrote:
> Remove a suggestion to write new commands in Perl or Shell to
> experiment. This advice was added in 6d0618a820a (Add
> Documentation/CodingGuidelines, 2007-11-08).
>
> Since then the consensus changed to having no new such commands unless
> necessary, and existing ones have been actively migrated to C.
>
> Signed-off-by: ??var Arnfj??r?? Bjarmason <avarab@gmail.com>

The patch looks good - but the Umlauts are garbled:
ISO-2022-JP is used ?

> ---
>  Documentation/CodingGuidelines | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index 45465bc0c98..b9cd55db6a8 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -416,11 +416,6 @@ For C programs:
>     that are made available to it by including one of the header files
>     it must include by the previous rule.
>
> - - If you are planning a new command, consider writing it in shell
> -   or perl first, so that changes in semantics can be easily
> -   changed and discussed.  Many Git commands started out like
> -   that, and a few are still scripts.
> -
>   - Avoid introducing a new dependency into Git. This means you
>     usually should stay away from scripting languages not already
>     used in the Git core command set (unless your command is clearly
> --
> 2.31.1.687.g1d87aeed692
>

  reply	other threads:[~2021-04-17  8:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17  8:43 [PATCH] CodingGuidelines: remove suggestion to write commands in Perl/SH Ævar Arnfjörð Bjarmason
2021-04-17  8:53 ` Torsten Bögershausen [this message]
2021-04-17 12:17 ` Bagas Sanjaya
2021-04-17 12:36   ` Ævar Arnfjörð Bjarmason
2021-04-17 20:28     ` brian m. carlson
2021-04-17 21:37       ` Ævar Arnfjörð Bjarmason
2021-04-17 22:10         ` brian m. carlson
2021-04-17 12:31 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-04-17 22:01 ` [PATCH] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210417085335.ib6m4jagiekeulec@tb-raspi4 \
    --to=tboegi@web.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).