git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lénaïc Huard" <lenaic@lhuard.fr>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Derrick Stolee" <dstolee@microsoft.com>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	lilinchao@oschina.cn, "Lénaïc Huard" <lenaic@lhuard.fr>
Subject: [PATCH v2 0/1] maintenance: fix two memory leaks
Date: Mon, 10 May 2021 21:59:08 +0200	[thread overview]
Message-ID: <20210510195909.621534-1-lenaic@lhuard.fr> (raw)
In-Reply-To: <20210509221613.474887-1-lenaic@lhuard.fr>

Hi!

Thank you for the code review.

I’ve moved the `strbuf_release(&line);` closer to the last point where
`line` is used.

And I’ve included Junio’s patch to address the missing
`free(local_path)` when `hold_lock_file_for_update()<0`.

Lénaïc Huard (1):
  maintenance: fix two memory leaks

 builtin/gc.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.31.1


  parent reply	other threads:[~2021-05-10 20:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 22:16 [PATCH] " Lénaïc Huard
2021-05-10  6:34 ` Junio C Hamano
2021-05-10  6:38 ` lilinchao
2021-05-10  7:11   ` Junio C Hamano
     [not found]   ` <0c04f7c2b15f11eb82baa4badb2c2b1178978@pobox.com>
2021-05-10  7:50     ` lilinchao
2021-05-10 19:59 ` Lénaïc Huard [this message]
2021-05-10 19:59   ` [PATCH v2 1/1] " Lénaïc Huard
2021-05-11 15:13     ` Derrick Stolee
2021-05-11  3:29   ` [PATCH v2 0/1] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210510195909.621534-1-lenaic@lhuard.fr \
    --to=lenaic@lhuard.fr \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lilinchao@oschina.cn \
    --cc=sunshine@sunshineco.com \
    --subject='Re: [PATCH v2 0/1] maintenance: fix two memory leaks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).