From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E531C433EF for ; Wed, 8 Sep 2021 14:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFD60610C8 for ; Wed, 8 Sep 2021 14:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351761AbhIHOOe (ORCPT ); Wed, 8 Sep 2021 10:14:34 -0400 Received: from verein.lst.de ([213.95.11.211]:39346 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbhIHOOd (ORCPT ); Wed, 8 Sep 2021 10:14:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 20BD567373; Wed, 8 Sep 2021 16:13:23 +0200 (CEST) Date: Wed, 8 Sep 2021 16:13:22 +0200 From: 'Christoph Hellwig' To: "Randall S. Becker" Cc: 'Christoph Hellwig' , 'Junio C Hamano' , 'Neeraj Singh' , "'Neeraj K. Singh via GitGitGadget'" , 'Git List' , 'Johannes Schindelin' , 'Jeff King' , 'Jeff Hostetler' , =?iso-8859-1?Q?'=C6var_Arnfj=F6r=F0?= Bjarmason' , "'Neeraj K. Singh'" Subject: Re: [PATCH v2 0/6] Implement a batched fsync option for core.fsyncObjectFiles Message-ID: <20210908141322.GA27146@lst.de> References: <20210908064958.GA29073@lst.de> <006d01d7a4b9$7cea64c0$76bf2e40$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <006d01d7a4b9$7cea64c0$76bf2e40$@nexbridge.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 08, 2021 at 09:57:34AM -0400, Randall S. Becker wrote: > possible. I know of at least 3 operating systems where that is a bad plan, and if you did, you would take the test suite down while > you were at it. I've just mentioned a good way to write a test for this feature on a specific platform. This is absolutely no judgement if that is a good plan on other platforms.