From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: johannes.schindelin@gmx.de, gitster@pobox.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH v2 0/2] protect git from a rogue editor
Date: Tue, 5 Oct 2021 00:46:46 -0700 [thread overview]
Message-ID: <20211005074648.86032-1-carenas@gmail.com> (raw)
In-Reply-To: <20211004072600.74241-1-carenas@gmail.com>
This is a reroll of cm/save-restore-terminal that removes the unnecessary
forward declaration in compat/terminal that was patiently reported[1] by
Junio.
Also changed the wording used in the first paragraph of the commit message
for the first patch, which hopefully has better grammar.
The series implements a way for git to save and restore the terminal
settings around EDITOR calls to avoid having to deal with botched output
if the editor misbehaves.
Carlo Marcelo Arenas Belón (2):
terminal: teach git how to save/restore its terminal settings
editor: save and reset terminal after calling EDITOR
compat/terminal.c | 75 +++++++++++++++++++++++++++++++++++++----------
compat/terminal.h | 3 ++
editor.c | 8 +++++
3 files changed, 71 insertions(+), 15 deletions(-)
[1] https://lore.kernel.org/git/CAPUEspiQrGDyYrBUmeMh0C1uPDjUE5d--5zT4vZZUdNr+xtAxA@mail.gmail.com/T/#u
Range-diff against v1:
1: 63cfeda4b7 ! 1: cf8306816d terminal: teach git how to save/restore its terminal settings
@@ compat/terminal.c
#if defined(HAVE_DEV_TTY) || defined(GIT_WINDOWS_NATIVE)
-static void restore_term(void);
-+void restore_term(void);
-
+-
static void restore_term_on_signal(int sig)
{
+ restore_term();
@@ compat/terminal.c: static void restore_term_on_signal(int sig)
static int term_fd = -1;
static struct termios old_term;
2: 0f409b6d00 = 2: d83cd3f712 editor: save and reset terminal after calling EDITOR
--
2.33.0.955.gee03ddbf0e
next prev parent reply other threads:[~2021-10-05 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 15:36 [RFC PATCH 0/2] protect git from a rogue editor Carlo Marcelo Arenas Belón
2021-10-02 15:36 ` [RFC PATCH 1/2] terminal: teach git how to save/restore its terminal settings Carlo Marcelo Arenas Belón
2021-10-02 15:36 ` [RFC PATCH 2/2] editor: save and reset terminal after calling EDITOR Carlo Marcelo Arenas Belón
2021-10-04 7:25 ` [PATCH 0/2] protect git from a rogue editor Carlo Marcelo Arenas Belón
2021-10-04 7:25 ` [PATCH 1/2] terminal: teach git how to save/restore its terminal settings Carlo Marcelo Arenas Belón
2021-10-04 16:36 ` Junio C Hamano
2021-10-04 17:27 ` Carlo Arenas
2021-10-04 18:10 ` Junio C Hamano
2021-10-04 18:33 ` Carlo Arenas
2021-10-04 7:26 ` [PATCH 2/2] editor: save and reset terminal after calling EDITOR Carlo Marcelo Arenas Belón
2021-10-04 16:38 ` [PATCH 0/2] protect git from a rogue editor Junio C Hamano
2021-10-05 7:46 ` Carlo Marcelo Arenas Belón [this message]
2021-10-05 7:46 ` [PATCH v2 1/2] terminal: teach git how to save/restore its terminal settings Carlo Marcelo Arenas Belón
2021-10-05 7:46 ` [PATCH v2 2/2] editor: save and reset terminal after calling EDITOR Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005074648.86032-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).