From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Eric Wong <e@80x24.org>,
users@linux.kernel.org, tools@linux.kernel.org,
git@vger.kernel.org
Subject: Re: b4: unicode control characters -- warn or remove?
Date: Tue, 2 Nov 2021 10:09:07 -0400 [thread overview]
Message-ID: <20211102140907.d7turl5zhaxkcp7w@meerkat.local> (raw)
In-Reply-To: <20211101202220.dlcebvckeoz6c26k@meerkat.local>
On Mon, Nov 01, 2021 at 04:22:20PM -0400, Konstantin Ryabitsev wrote:
> I think the following would be a sane check:
>
> 1. are there unicode control characters (CCs) present?
> 2. are there other characters from RTL languages present in the same line?
>
> if both 1 && 2 are true, this is a legitimate use of Unicode CCs. If only 1 is
> true, then it's likely worth a warning.
I implemented this solution in b4 master, so it should error out only when it
finds control characters without any "other letter" unicode character category
present in the same line (where Hebrew, Arabic, etc live). There's probably
still a way to take advantage of this, but hopefully it's a lot less trivial
now and less likely to go unnoticed by the reviewer.
The error message will point where it found the problem:
WARNING: Message contains suspicious unicode control characters!
Subject: [PATCH 1/2] SPI: Add SPI driver for Sunplus SP7021
Line: + /* } if (isAdmin) begin admins only */
-----------^
Char: RIGHT-TO-LEFT OVERRIDE (0x202e)
If you are sure about this, rerun with the right flag to allow.
One can rerun with --allow-unicode-control-chars to override this.
-K
prev parent reply other threads:[~2021-11-02 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211101175020.5r4cwmy4qppi7dis@meerkat.local>
2021-11-01 19:09 ` b4: unicode control characters -- warn or remove? Eric Wong
2021-11-01 19:17 ` Konstantin Ryabitsev
2021-11-01 20:02 ` Ævar Arnfjörð Bjarmason
2021-11-01 20:22 ` Konstantin Ryabitsev
2021-11-01 20:49 ` Pavel Machek
2021-11-01 21:02 ` Konstantin Ryabitsev
2021-11-02 14:09 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102140907.d7turl5zhaxkcp7w@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=avarab@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).